Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up rtweekend.h introduction and use #1476

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix up rtweekend.h introduction and use #1476

merged 3 commits into from
Mar 29, 2024

Conversation

hollasch
Copy link
Collaborator

Resolves #1473

@hollasch hollasch added this to the v4.0.0-alpha.2-release milestone Mar 29, 2024
@hollasch hollasch requested a review from a team March 29, 2024 02:58
@hollasch hollasch self-assigned this Mar 29, 2024
Copy link
Contributor

@armansito armansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Otherwise looks good.

books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
Copy link
Contributor

@rupsis rupsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly editing suggestions.

Only requesting changes because missing ] breaks page rendering.

books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
books/RayTracingInOneWeekend.html Show resolved Hide resolved
@hollasch hollasch merged commit 76e4c82 into dev Mar 29, 2024
@hollasch hollasch deleted the fix-rtweekend-h-intro branch March 29, 2024 19:07
Copy link
Contributor

@armansito armansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated approval

books/RayTracingInOneWeekend.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants