Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "Lights" paragraph in "What's next?" list, adjust numbering. #467

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Correct "Lights" paragraph in "What's next?" list, adjust numbering. #467

merged 3 commits into from
Apr 18, 2020

Conversation

shaunplee
Copy link
Contributor

In the "What's next?" list in Chapter 13, it seems like the paragraphs:

  1. Lights. You can do this explicitly, by sending shadow rays to lights. Or it can be done implicitly by making some objects emit light,
  2. Biasing scattered rays toward them, and then downweighting those rays to cancel out the bias. Both work. I am in the minority in favoring the latter approach.

should actually be part of the same paragraph. Combining these paragraphs also means renumbering the remaining paragraphs.

@trevordblack
Copy link
Collaborator

Please create a separate issue.

Also, as far as "What's Next" we're in the middle of figuring out how we want to organize all of them together. See #407

If you have any ideas, feel free to throw them in there

@shaunplee
Copy link
Contributor Author

Ok. New issue opened #472

books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
books/RayTracingInOneWeekend.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@hollasch hollasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hollasch hollasch merged commit b97c482 into RayTracing:dev-patch Apr 18, 2020
@shaunplee shaunplee deleted the dev-patch branch April 18, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants