Skip to content

Commit

Permalink
unit tests foralready resolved issue, closes #3334 (#3748)
Browse files Browse the repository at this point in the history
  • Loading branch information
jangorecki authored and mattdowle committed Aug 13, 2019
1 parent a2e7f5e commit 2922591
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@
25. Slight fix to the logic for auto-naming the `by` clause for using a custom function like `evaluate` to now be named `evaluate` instead of the name of the first symbolic argument, [#3758](https://github.com/Rdatatable/data.table/issues/3758).
26. Column binding of zero column `data.table` will now work as expected, [#3334](https://github.com/Rdatatable/data.table/issues/3334). Thanks to @kzenstratus for the report.
#### NOTES
1. `rbindlist`'s `use.names="check"` now emits its message for automatic column names (`"V[0-9]+"`) too, [#3484](https://github.com/Rdatatable/data.table/pull/3484). See news item 5 of v1.12.2 below.
Expand Down
3 changes: 3 additions & 0 deletions inst/tests/tests.Rraw
Original file line number Diff line number Diff line change
Expand Up @@ -15646,6 +15646,9 @@ test(2074.39, fread('a,b\n"Inf,2\n'), data.table(a='"Inf', b=2L), warning="Found
test(2074.40, fread('a\n1', na.strings=character(), verbose=TRUE), output='No NAstrings provided')
test(2074.41, fread('a\n1', na.strings='9', verbose=TRUE), output='One or more of the NAstrings looks like a number')

# cbind 0 cols, #3334
test(2075, data.table(data.table(a=1), data.table()), data.table(data.table(a=1)))


###################################
# Add new tests above this line #
Expand Down

0 comments on commit 2922591

Please sign in to comment.