-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.SD vignette based on SO answer #3412
Comments
Sounds great! Why not go for a "special symbols" vignette altogether? Could you not use the same flights data we already use though? |
Vignette only about special symbols sounds cryptic. Maybe vignette about complex queries, which will cover special symbols and tricks like { inside j, or |
Because the choice of data is mentioned: in general, I think it's better with minimal data sets in examples and vignettes - so much easier to track results following each step of code. To be honest, I don't think we need 253316 rows (flights) or 44963 (Pitching) to explain and demonstrate the actual functionality of Benchmarking on large data sets could be provided in a separate vignette. Just my 2c. |
@Henrik-P I have to disagree.
Could we use a subset of the data? Sure, if we're careful to preserve reproducibility. In terms of "tracking results", this is easily superable -- vignette writer can drill down to a specific group as needed.
|
They are not tiny for human eye, I think this is what @Henrik-P mean. If we can have 20-40 rows data to present same functionality, then it will be easier for readers to follow. |
I'm going to stick with the original data. I think small data is good for the Since |
This SO answer
Encouraged to include as vignette:
I want to be sure to add a bit about chaining since I mentioned but forgot to include that in the original answer.
Another hold-up is the use of
Lahman
data. I guess I can try and find a URL instead of adding a Suggests for that package...The text was updated successfully, but these errors were encountered: