Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test case for reading large integer #2344

Merged
merged 3 commits into from
Sep 8, 2017
Merged

Added a test case for reading large integer #2344

merged 3 commits into from
Sep 8, 2017

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Sep 8, 2017

The issue itself was fixed in e79d63b, this PR merely adds a test case before the issue can be closed.

Closes #2250
Closes #1618

@st-pasha st-pasha added the fread label Sep 8, 2017
@st-pasha st-pasha added this to the v1.10.6 milestone Sep 8, 2017
@st-pasha st-pasha self-assigned this Sep 8, 2017
@codecov-io
Copy link

codecov-io commented Sep 8, 2017

Codecov Report

Merging #2344 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   91.14%   91.11%   -0.04%     
==========================================
  Files          61       61              
  Lines       11785    11785              
==========================================
- Hits        10742    10738       -4     
- Misses       1043     1047       +4
Impacted Files Coverage Δ
src/forder.c 93.94% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e704ebe...c6d8a33. Read the comment docs.

@mattdowle mattdowle merged commit f800b22 into master Sep 8, 2017
@mattdowle mattdowle deleted the issue2250 branch September 8, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fread garbles integers that are too big fread could read integers > 2^63 as character
3 participants