-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
na.strings getOption() added so ,, can be read as NA by default in future #2652
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3057372
,, now read as NA not empty string
mattdowle d3fc8ed
nocov on dev util
mattdowle 5f7b324
Added test for #2214
mattdowle 09cadbe
Added test for #2217
mattdowle d58f73c
Updated ?fread to resolve #2586
mattdowle 6fbc9c1
print NA as <NA>
mattdowle 88674d2
na.strings now getOption with no default change yet
mattdowle 50c5cc6
Merge branch 'master' into na_blank
mattdowle bf04b2e
New tests need na.strings= as default change is now postponed
mattdowle 30d1c0b
Breaking changes section added to NEWS. fread(logical01=getOption) too.
mattdowle fd1e4ce
Merge branch 'master' into na_blank
mattdowle e03095f
Merge branch 'master' into na_blank
mattdowle 94327ea
Merge branch 'master' into na_blank
mattdowle 2070b85
Merge branch 'master' into na_blank
mattdowle 90d42f9
Reverted logical01 to FALSE (old default, no change) thanks to review…
mattdowle b679215
Coverage
mattdowle 4814608
Link added to getOption 100x speedup submitted to R-core
mattdowle 2d2267c
New test covers what it was supposed to now.
mattdowle 1b035ac
NEW item only. Added PR link and embellished wording.
mattdowle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice, no need for
quote = TRUE
argument by default 👍