bquote usage excluded from replace_dot_alias #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haha whoops. fails quite catastrophically. CI is on 🔥 ... fixing |
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 93.43% 93.43% +<.01%
==========================================
Files 61 61
Lines 12295 12296 +1
==========================================
+ Hits 11488 11489 +1
Misses 807 807
Continue to review full report at Codecov.
|
mattdowle
changed the title
… no difference, but I think it will as per #2731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1912
bquoteitself has a different usage of.()which was being undone byreplace_dot_alias; an exception is made. AFAIKbquoteis the only function inbasewith this behavior (not that this is a particularly searchable issue), so this should suffice.h/t @ecoRoland for the code