Clear rchk messages on CRAN #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdowle
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
+ Coverage 90.85% 90.87% +0.01%
==========================================
Files 61 61
Lines 11736 11733 -3
==========================================
- Hits 10663 10662 -1
+ Misses 1073 1071 -2
Continue to review full report at Codecov.
|
|
Local results of |
Closed
mattdowle
added a commit
that referenced
this pull request
Sep 20, 2018
…ts, #3033. This NEWS item is live on GitHub and will reflect on CRAN in the next release. Realized missing news item as a result of tweeting thanks: https://twitter.com/MattDowle/status/1042835186801471488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current rchk messages on CRAN reproduced locally.
Function chmatch2_old
[UP] calling allocating function unlist2(V) with a fresh pointer (l <arg 1>) data.table/src/rbindlist.c:825
Function fmelt [UP] unprotected variable dtnames while calling allocating function Rf_allocVector data.table/src/fmelt.c:663
[UP] unprotected variable dtnames while calling allocating function preprocess(?,?,?,V,V,?,?,?) data.table/src/fmelt.c:664
[UP] allocating function getvaluecols may destroy its unprotected argument (dtnames <arg 2>), which is later used. data.table/src/fmelt.c:670
[UP] calling allocating function getvaluecols with a fresh pointer (dtnames <arg 2>) data.table/src/fmelt.c:670
[UP] allocating function getvarcols may destroy its unprotected argument (dtnames <arg 2>), which is later used. data.table/src/fmelt.c:671
[UP] calling allocating function getvarcols with a fresh pointer (dtnames <arg 2>) data.table/src/fmelt.c:671
[UP] allocating function getidcols may destroy its unprotected argument (dtnames <arg 2>), which is later used. data.table/src/fmelt.c:672
[UP] unprotected variable dtnames while calling allocating function Rf_allocVector data.table/src/fmelt.c:675
[UP] unprotected variable dtnames while calling allocating function Rf_allocVector data.table/src/fmelt.c:684
Function gmax
[UP] calling allocating function Rf_coerceVector(V,?) with a fresh pointer (ans <arg 1>) data.table/src/gsumm.c:391
Function gmin
[UP] calling allocating function Rf_coerceVector(V,?) with a fresh pointer (ans <arg 1>) data.table/src/gsumm.c:260
Function reorder
[PB] has possible protection stack imbalance data.table/src/reorder.c:109
Function setselfref
[UP] calling allocating function R_MakeExternalPtr with argument allocated using Rf_getAttrib(?,S:names) data.table/src/assign.c:36
Function userOverride
[UP] calling allocating function chmatch(?,V,?,?) with argument allocated using Rf_getAttrib(?,S:names) data.table/src/freadR.c:227