-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fwrite coerces input to data.table when given a matrix #3125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the warning before the conversion, since that step might be slow
I am not sure if warning is really necessary. Coercing can be slow but I think there is no other faster alternative, so it is still proper way to go. matrix(1:3, nrow=1, ncol=3)
matrix(1:3, nrow=3, ncol=1)
matrix(1:9, nrow=3, ncol=3) and matrices having |
…g' 2) Added more tests 3) fixed some minor spacing issues
Codecov Report
@@ Coverage Diff @@
## master #3125 +/- ##
==========================================
+ Coverage 92.34% 92.34% +<.01%
==========================================
Files 61 61
Lines 11582 11585 +3
==========================================
+ Hits 10695 10698 +3
Misses 887 887
Continue to review full report at Codecov.
|
Hi @MichaelChirico @jangorecki |
Closes #2613
When given a matrix as an input, fwrite now coerces it to a class data.table, to avoid an error in the stopifnot(is.list(x))