Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT[i,cols] calls CsubsetDT #3213

Merged
merged 6 commits into from
Dec 14, 2018
Merged

DT[i,cols] calls CsubsetDT #3213

merged 6 commits into from
Dec 14, 2018

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Dec 13, 2018

Closes #3212
Closes #3214

Reveals #3215 which is unchanged from v1.11.8 and left open after this PR.

@mattdowle mattdowle added this to the 1.12.0 milestone Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #3213 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   94.57%   94.59%   +0.02%     
==========================================
  Files          61       61              
  Lines       11737    11735       -2     
==========================================
+ Hits        11100    11101       +1     
+ Misses        637      634       -3
Impacted Files Coverage Δ
src/subset.c 100% <100%> (ø) ⬆️
R/data.table.R 95.18% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daefad...7ba310d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #3213 into master will decrease coverage by 0.06%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3213      +/-   ##
=========================================
- Coverage   94.57%   94.5%   -0.07%     
=========================================
  Files          61      61              
  Lines       11737   11747      +10     
=========================================
+ Hits        11100   11102       +2     
- Misses        637     645       +8
Impacted Files Coverage Δ
src/subset.c 100% <100%> (ø) ⬆️
R/data.table.R 94.64% <83.33%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daefad...10ccd65. Read the comment docs.

@mattdowle mattdowle merged commit 5b16cc5 into master Dec 14, 2018
@mattdowle mattdowle deleted the subset2 branch December 14, 2018 00:29
@mattdowle mattdowle mentioned this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant