Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Intel compiler bug #3648

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Fix for Intel compiler bug #3648

merged 2 commits into from
Jun 19, 2019

Conversation

hroptatyr
Copy link
Contributor

@hroptatyr hroptatyr commented Jun 18, 2019

Closes #3647
Calculate skip condition after and separate from key counting.

Calculate `skip` condition after and separate from key counting.
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #3648 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3648      +/-   ##
==========================================
- Coverage   98.25%   98.25%   -0.01%     
==========================================
  Files          69       69              
  Lines       13088    13087       -1     
==========================================
- Hits        12860    12859       -1     
  Misses        228      228
Impacted Files Coverage Δ
src/forder.c 99.71% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024399a...b4e0981. Read the comment docs.

@mattdowle mattdowle changed the title proposal for #3647 Fix for Intel compiler bug Jun 19, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Jun 19, 2019
@mattdowle
Copy link
Member

Great, thanks for the report and fix. I'll just add a minor tweak, a news item, and merge.

@mattdowle mattdowle merged commit 9c7b2d8 into Rdatatable:master Jun 19, 2019
@mattdowle
Copy link
Member

This was a code contribution, so I'm sorry @hroptatyr, I should have added you to DESCRIPTION as a contributor at the time. I'll correct my mistake now in a commit to master linking to this PR.
Found as a result of following up on discussion at the end of #1236.
(This contribution was after the license change from GPL to MPL so it doesn't need to be included in the forthcoming retrospective-permission PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forder with icc 2019/openmp 4 skips radix sort on final descent
2 participants