Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3931
Moved the malloc up before the parallel region. So that it can have its own more detailed error message and to avoid any concern about malloc thread safety on solaris 10.
Changed
failed
to bool and only write true, so it can be naked in the usual way.Compress and write error codes separated explicitly. Probably overkill but to leave no doubt in case both positive and negative error codes are possible on Solaris, and to avoid needing to ask Prof Ripley to test a 2nd time.
The thread which fails and reaches ordered section first writes its error code thread-safely.