Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace fwrite-zlib on solaris #3954

Merged
merged 5 commits into from
Oct 9, 2019
Merged

trace fwrite-zlib on solaris #3954

merged 5 commits into from
Oct 9, 2019

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Oct 9, 2019

Closes #3931

Moved the malloc up before the parallel region. So that it can have its own more detailed error message and to avoid any concern about malloc thread safety on solaris 10.
Changed failed to bool and only write true, so it can be naked in the usual way.
Compress and write error codes separated explicitly. Probably overkill but to leave no doubt in case both positive and negative error codes are possible on Solaris, and to avoid needing to ask Prof Ripley to test a 2nd time.
The thread which fails and reaches ordered section first writes its error code thread-safely.

  • sent to Prof Ripley to run on Solaris. Hopefully it will pass. If not, this should provide more detail on the error.
  • remove temporary verbose just after test 1658.41

…e true only with distinct compress/write error codes. To trace Solaris.
@mattdowle mattdowle added this to the 1.12.5 milestone Oct 9, 2019
@mattdowle
Copy link
Member Author

mattdowle commented Oct 9, 2019

MacOS Travis has been running 27 mins so far. Frustrating. That's why it's off in dev. Linux finished in 10 mins.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #3954 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3954      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          72      72              
  Lines       13642   13648       +6     
=========================================
+ Hits        13561   13567       +6     
  Misses         81      81
Impacted Files Coverage Δ
src/fwrite.c 97.86% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5c3d3...e676127. Read the comment docs.

@mattdowle mattdowle merged commit 5fc6dde into master Oct 9, 2019
@mattdowle mattdowle deleted the fwrite_solaris branch October 9, 2019 19:09
@mattdowle mattdowle mentioned this pull request Oct 13, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fwrite compression error on Solaris
1 participant