Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand & improve error message for grouping by unsupported types #4309

Merged
merged 4 commits into from
Jun 14, 2021

Conversation

MichaelChirico
Copy link
Member

Closes #4308

@mattdowle mattdowle added this to the 1.14.1 milestone Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #4309 (848ddeb) into master (5421e7a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 848ddeb differs from pull request most recent head f50677f. Consider uploading reports for the commit f50677f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4309   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          75       75           
  Lines       14807    14808    +1     
=======================================
+ Hits        14729    14730    +1     
  Misses         78       78           
Impacted Files Coverage Δ
R/data.table.R 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5421e7a...f50677f. Read the comment docs.

@mattdowle mattdowle merged commit 24191e7 into master Jun 14, 2021
@mattdowle mattdowle deleted the by-list-error branch June 14, 2021 20:37
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when trying to group by a list column
3 participants