Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when as.data.frame dispatches to list method, force input to list #4529

Merged
merged 6 commits into from
Apr 27, 2021

Conversation

MichaelChirico
Copy link
Member

Closes #4526

I'm not sure if there's an efficiency implication to the as.list but it feels right to do regardless.

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #4529 (be116e5) into master (16df423) will not change coverage.
The diff coverage is 100.00%.

❗ Current head be116e5 differs from pull request most recent head 84efb7e. Consider uploading reports for the commit 84efb7e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4529   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14448    14448           
=======================================
  Hits        14365    14365           
  Misses         83       83           
Impacted Files Coverage Δ
R/as.data.table.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16df423...84efb7e. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.1 milestone Apr 15, 2021
NEWS.md Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Member Author

thanks! looking better

@mattdowle mattdowle merged commit 7d1cf04 into master Apr 27, 2021
@mattdowle mattdowle deleted the issue4526 branch April 27, 2021 19:29
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as.data.table(dfidx) fails
3 participants