Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure fix #4662

Merged
merged 1 commit into from
Aug 4, 2020
Merged

configure fix #4662

merged 1 commit into from
Aug 4, 2020

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Aug 4, 2020

Follow up to #3984 which renamed Makevars to Makevars.in and now requires the end of configure to run
Closes #4640
Closes #4650
Closes #4652

removed the exit 0
put the zlib version output into an else (that was why the exit 0 was there because there was nothing after the zlib version output originally, i.e. before #3984)
added the -- for FreeBSD, thanks to @wesnm
changed wording for Mac to explain that zlib is built in there
news item

@mattdowle mattdowle added this to the 1.13.1 milestone Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #4662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4662   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          73       73           
  Lines       14244    14244           
=======================================
  Hits        14189    14189           
  Misses         55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d83d1...4e88433. Read the comment docs.

@mattdowle mattdowle merged commit 3715f72 into master Aug 4, 2020
@mattdowle mattdowle deleted the config_fix branch August 4, 2020 21:18
hongyuanjia pushed a commit to hongyuanjia/data.table that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failure due to zlib test in configure Warning message CRAN oldrel-macos install fails
1 participant