Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra print in test summary #4850

Merged
merged 2 commits into from
Dec 16, 2020
Merged

extra print in test summary #4850

merged 2 commits into from
Dec 16, 2020

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Dec 16, 2020

Output I am getting after first commit in this PR.

All 8259 tests (last 1913.24) in tests/tests.Rraw completed ok in 57.3s elapsed (00:01:12 cpu)

and after fixing the problem, in second commit.

All 9993 tests (last 2161.2) in inst/tests/tests.Rraw completed ok in 00:01:32 elapsed (00:01:49 cpu)

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #4850 (1084041) into master (87b8c15) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4850   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14592    14592           
=======================================
  Hits        14515    14515           
  Misses         77       77           
Impacted Files Coverage Δ
R/test.data.table.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b8c15...1084041. Read the comment docs.

@mattdowle
Copy link
Member

Output I am getting after first commit in this PR.

The first commit, which appears to be 1084041, appears to just change the type of quotes within a comment. Because that change is in a comment, I don't see why that would change anything.

and after fixing the problem

what problem exactly? I'm looking at the change to a comment and wondering why that changes anything.

@mattdowle
Copy link
Member

I don't see any reason why not to merge this PR, though. In this case i don't need to understand the reason. Including env$prevtest in the last line is fine, whatever the reason.
Will merge after version bump.

@mattdowle mattdowle added this to the 1.13.7 milestone Dec 16, 2020
@mattdowle mattdowle merged commit 7aa22ee into master Dec 16, 2020
@mattdowle mattdowle deleted the test-mention-last branch December 16, 2020 19:32
@jangorecki
Copy link
Member Author

jangorecki commented Dec 17, 2020

@mattdowle first commit was cb6cae9. Second commit was 1084041 that changed quotes in comment making test script to not quit early during parsing.

@mattdowle mattdowle modified the milestones: 1.13.7, 1.14.0 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants