Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracing of zlib/fwrite for Solaris #4860

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

mattdowle
Copy link
Member

Follow up to #4845 and #4099 to remove the tracing now it is passing on CRAN's Solaris.
Can always fetch this code from the history should we need it again.

@mattdowle mattdowle added this to the 1.13.7 milestone Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #4860 (e3210da) into master (05202fe) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4860      +/-   ##
==========================================
- Coverage   99.47%   99.47%   -0.01%     
==========================================
  Files          73       73              
  Lines       14592    14560      -32     
==========================================
- Hits        14515    14483      -32     
  Misses         77       77              
Impacted Files Coverage Δ
src/fwrite.c 97.70% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05202fe...e3210da. Read the comment docs.

@mattdowle mattdowle merged commit 33d67c4 into master Dec 30, 2020
@mattdowle mattdowle deleted the fwrite_solaris_remove_tracing branch December 30, 2020 23:38
@mattdowle mattdowle modified the milestones: 1.13.7, 1.14.0 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant