Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop exporting .rbind.data.table in R>=4.0.0 #5600

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Stop exporting .rbind.data.table in R>=4.0.0 #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d15627
Stop exporting .rbind.data.table in R>=4.0.0
mattdowle Feb 16, 2023
3c7ea85
added pr number to news item and code now that's known
mattdowle Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,18 @@ if (getRversion() >= "4.0.0") {
# if we register these (new in v1.12.6) methods always though, the previous workaround no longer works in R<4.0.0. Hence only register in R>=4.0.0.
S3method(cbind, data.table)
S3method(rbind, data.table)
} else {
# and if we export but don't register in R < 4.0.0 we get this note:
# > Found the following apparent S3 methods exported but not registered:
# > cbind.data.table rbind.data.table
# in addition to errors in tests 324, 326, 414.1, 414.2, 442, 445, 451
# export(cbind.data.table)
# export(rbind.data.table)
# A revdep using rbind.data.frame() directly before (which data.table changed in base) should change to rbind() generic and that should work
# in all combinations of R before/after 4.0.0 and data.table before/after 1.12.6, so long as data.table is installed using the same major
# version of R (and that is checked in .onLoad with error if not).
export(.rbind.data.table) # only export in R<4.0.0 where it is still used; R-devel now detects it is missing doc, #5600
}
# else {
# # and if we export but don't register in R < 4.0.0 we get this note:
# # > Found the following apparent S3 methods exported but not registered:
# # > cbind.data.table rbind.data.table
# # in addition to errors in tests 324, 326, 414.1, 414.2, 442, 445, 451
# export(cbind.data.table)
# export(rbind.data.table)
# # A revdep using rbind.data.frame() directly before (which data.table changed in base) should change to rbind() generic and that should work
# # in all combinations of R before/after 4.0.0 and data.table before/after 1.12.6, so long as data.table is installed using the same major
# # version of R (and that is checked in .onLoad with error if not).
# }
export(.rbind.data.table) # continue to export for now because it has been exported in the past so it may be depended on
S3method(dim, data.table)
S3method(dimnames, data.table)
S3method("dimnames<-", data.table)
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,8 @@

2. An out of bounds read when combining non-equi join with `by=.EACHI` has been found and fixed thanks to clang ASAN, [#5598](https://github.com/Rdatatable/data.table/issues/5598). There was no bug or consequence because the read was followed (now preceded) by a bounds test.

3. `.rbind.data.table` (note the leading `.`) is no longer exported when `data.table` is installed in R>=4.0.0 (Apr 2020), [#5600](https://github.com/Rdatatable/data.table/pull/5600). It was never documented which R-devel now detects and warns about. It is only needed by `data.table` internals to support R<4.0.0; see note 1 in v1.12.6 (Oct 2019) below in this file for more details.


# data.table [v1.14.6](https://github.com/Rdatatable/data.table/milestone/27?closed=1) (16 Nov 2022)

Expand Down