Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitattributes to force LF #6386

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Update gitattributes to force LF #6386

merged 5 commits into from
Aug 20, 2024

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Aug 20, 2024

Follow-up to #6378 and #6369

My understanding is this works as follows:

  1. Every file is treated as a plain text file, with LF line endings (i.e. \n)
  2. Except for certain binary file types: .ico, .mo, .png, .RData
  3. And except in the inst/tests directory, where files are binary (-text) by default
  4. Except for .Rraw files in inst/tests, which should also be treated as plain text LF

@MichaelChirico MichaelChirico requested a review from a team as a code owner August 20, 2024 21:23
Copy link
Member

@Anirban166 Anirban166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of the syntax! (can just keep adding to the list of binaries to be excluded from being treated as text files)

@MichaelChirico MichaelChirico merged commit 6ead6aa into master Aug 20, 2024
7 checks passed
@MichaelChirico MichaelChirico deleted the force-lf branch August 20, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants