Skip to content
This repository has been archived by the owner on Oct 26, 2024. It is now read-only.

Conversation

ILoveOpenSourceApplications
Copy link
Contributor

Closes #8

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the base branch from main to dev August 28, 2024 17:34
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compact channel hides channels in some places like search the last time I saw it. I think it also only happens in tablet mode

@ILoveOpenSourceApplications
Copy link
Contributor Author

This is how the header looks currently:
Screenshot_20240828_233918_YouTube

@ILoveOpenSourceApplications
Copy link
Contributor Author

They have merged the header with the channel profile, basically making into one. If needed then the name of the patch can be changed accordingly.

@ILoveOpenSourceApplications
Copy link
Contributor Author

Maybe something like Hide channel profile in search results?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Sep 17, 2024

Yeah, although I don't see why anyone would want that. It would be better to remove this patch instead. The gain of having it is not really much.

@ILoveOpenSourceApplications
Copy link
Contributor Author

A more user-centric approach would be to present users with a choice while also allowing users to determine their preference which would enhance the overall user experience.

@oSumAtrIX
Copy link
Member

With PR ReVanced/revanced-patches#3462, ReVanced Integrations has been merged into ReVanced Patches. This PR must be reopened in the ReVanced Patches repository and adjusted to the new build system. ReVanced Integration is now understood as "extensions" according to the ReVanced Patcher API. As extensions are now on a per-patch basis, this PR may be subject to a separate extension. If not, the PR can change the shared extension in ReVanced Patches.

Thanks, for the PR.

@oSumAtrIX oSumAtrIX closed this Oct 26, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the fix/hide-search-result-header branch October 30, 2024 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(YouTube - Hide search result shelf header): Search result headers showing up when searching
2 participants