fix: hide patch button #1284

BenjaminHalko · 2023-09-20T22:02:58Z

Hides the patch button if no patches have been selected

validcube

👋 Hello there!

Please rebase your commit 65a3d78 ontop of the latest compose-dev branch and force-push it to hide-patch-button as there are unrelated changes not pertaining to this PR.

Changes that are not pertaining to this Pull Request will be marked in review.

.github/workflows/pr-build.yml

.github/workflows/release.yml

app/build.gradle.kts

BenjaminHalko · 2023-09-21T15:52:12Z

@validcube done. sorry about that

app/src/main/java/app/revanced/manager/ui/screen/PatchesSelectorScreen.kt

BenjaminHalko · 2023-09-25T23:00:27Z

Ushie · 2023-09-25T23:02:45Z

The colors are definitely off, I believe you can check the source of Floating Action Button and get the colors for the disabled state of it

BenjaminHalko · 2023-09-25T23:11:51Z

Floating action buttons have no disabled state though

Ushie · 2023-09-25T23:20:38Z

Ah, I was under the impression that the non-extended one had a disabled state for some reason

Maybe copy it from the M3 Button component?
By following the Filled Button's disabled props from here, we get:

Container:
- Color: onSurface
- Opacity: 0.12
Label and Icon:
- Color: onSurface
- Opacity: 0.38

Can you try these out?

It also seems to set an elevation level for the container, but I'm not sure we need that, especially considering a FAB has a different elevation to a regular button to begin with

BenjaminHalko · 2023-09-25T23:23:49Z

I don't know if changing the opacity is a wise idea.

BenjaminHalko · 2023-09-25T23:25:48Z

those colors might work though, if they weren't transparent.

BenjaminHalko · 2023-09-25T23:28:41Z

Much better

Ushie · 2023-09-25T23:30:07Z

hm, something feels wrong about this, I'm not sure they should be this dark, how does it look with the rest of the screen?

BenjaminHalko · 2023-09-25T23:30:48Z

Yeah I agree

BenjaminHalko · 2023-09-25T23:35:22Z

Using darkGray for the back and gray for the text. I think light mode has lightgray for back and gray for text

BenjaminHalko · 2023-09-25T23:43:41Z

Found this: https://m3.material.io/foundations/interaction/states/applying-states#285e182f-9faa-416c-b12f-29b98ebf8ecf

If the action represented in the FAB is unavailable, the FAB should not appear

Maybe we should have the patch button disappear...

Axelen123 · 2023-09-26T16:18:35Z

Found this: m3.material.io/foundations/interaction/states/applying-states#285e182f-9faa-416c-b12f-29b98ebf8ecf

If the action represented in the FAB is unavailable, the FAB should not appear

Maybe we should have the patch button disappear...

Oh, I see. Sorry for the trouble.

@PalmDevs whats the best way to deal with this?

PalmDevs · 2023-09-26T16:30:35Z

@PalmDevs whats the best way to deal with this?

Simply hide the FAB like M3 guidelines said. Don't forget to animate it as well.

BenjaminHalko · 2023-10-14T20:33:33Z

@PalmDevs There seems to be a bug with wrapping ExtendedFloatingActionButton around AnimatedVisibility

BenjaminHalko · 2023-10-14T20:38:05Z

But just removing the button should work for now.

PalmDevs · 2023-10-14T20:42:39Z

Does it just hide the button without animating? If the code works after that bug is fixed, then it should be fine. Can I have a screen recording?

BenjaminHalko · 2023-10-14T20:47:07Z

For context this is where I am placing AnimatedVisibility.

Once the floating button disappears it never comes back. I also tested it by wrapping AnimatedVisibility around the text on the button and that worked just fine.

Screen_Recording_20231014_134529_ReVanced.Manager.Debug.mp4

BenjaminHalko · 2023-10-14T20:47:41Z

Am I just using it wrong?

BenjaminHalko · 2023-10-16T18:05:20Z

@PalmDevs Is this ready to merge or should I try to get the animation working instead of just hiding it.

PalmDevs · 2023-10-16T18:18:06Z

@PalmDevs Is this ready to merge or should I try to get the animation working instead of just hiding it.

Up to you, animating isn't really high priority. You can always do later before stable release.

Axelen123 · 2023-10-16T18:31:27Z

FYI: the prerelease checklist is tiny.

I would just hide it for now

PalmDevs

UI looks

al (L)
gee (G)
tee (T)
em (M)

👍

# [1.9.0-dev.1](v1.8.0...v1.9.0-dev.1) (2024-01-23) ### Bug Fixes * broken logo in about page on release builds ([4c1ad86](4c1ad86)) * buildfile syntax ([ReVanced#66](https://github.com/BenjaminHalko/revanced-manager/issues/66)) ([b472a36](b472a36)) * bundles not loading on Android 14 ([18cfb56](18cfb56)) * contributors screen fix ([ReVanced#1256](https://github.com/BenjaminHalko/revanced-manager/issues/1256)) ([9408857](9408857)) * delete temporary files ([ReVanced#1341](https://github.com/BenjaminHalko/revanced-manager/issues/1341)) ([723f9cd](723f9cd)) * **deps:** use correct work-runtime version string ([2bb51c1](2bb51c1)) * disable `WebView` history ([ReVanced#1278](https://github.com/BenjaminHalko/revanced-manager/issues/1278)) ([a86923a](a86923a)) * don't store app list in parcel ([55f2256](55f2256)) * dont crash when the bundle cannot be downloaded ([93f3e27](93f3e27)) * exclude x86 aapt2 binary from release builds ([ReVanced#1126](https://github.com/BenjaminHalko/revanced-manager/issues/1126)) ([381daff](381daff)) * gradlew permissions on unix ([cb0150a](cb0150a)) * handle exceptions when checking for bundle updates ([32e8a37](32e8a37)) * hide patch button ([ReVanced#1284](https://github.com/BenjaminHalko/revanced-manager/issues/1284)) ([5aefb3b](5aefb3b)) * **installer:** make the correct column scrollable ([1eac42d](1eac42d)) * **installer:** progress tracking ([272d911](272d911)) * **installer:** properly track worker state ([ReVanced#32](https://github.com/BenjaminHalko/revanced-manager/issues/32)) ([971277e](971277e)) * **installer:** save step incorrectly being marked as completed ([18cbe51](18cbe51)) * **installer:** sign and install on threads ([4ae9904](4ae9904)) * **installer:** use correct bg colour for dialog ([7525e52](7525e52)) * **installer:** use correct elevation level ([d9953b1](d9953b1)) * jvm signature clash error ([4b12ae1](4b12ae1)) * library info not being embedded ([299aaa2](299aaa2)) * load patch bundles earlier ([9cab919](9cab919)) * minify crash on building release ([ReVanced#1245](https://github.com/BenjaminHalko/revanced-manager/issues/1245)) ([b4dfcf1](b4dfcf1)) * more android 34 fixes ([64ec73d](64ec73d)) * option state crash ([ReVanced#1456](https://github.com/BenjaminHalko/revanced-manager/issues/1456)) ([5fff0a2](5fff0a2)) * overlapping issue in application selection page ([ReVanced#1128](https://github.com/BenjaminHalko/revanced-manager/issues/1128)) ([372ce17](372ce17)) * parcel error for nullable types ([2bd8463](2bd8463)) * pass worker inputs without serialization ([ReVanced#44](https://github.com/BenjaminHalko/revanced-manager/issues/44)) ([4302ea8](4302ea8)) * patch options reset button being broken ([0b9889e](0b9889e)) * **patcher:** add notification and wakelock to worker; chore: add app icon ([b8a51d3](b8a51d3)) * patches not being reloaded ([9586a9c](9586a9c)) * **patches selector:** copy the selected patches list ([762bfa8](762bfa8)) * perform selected app operations in the correct order ([cc89784](cc89784)) * permission error when using installed app ([f6563b2](f6563b2)) * progress bar not updating ([f38b31a](f38b31a)) * providers.gradleProperty ([ReVanced#1223](https://github.com/BenjaminHalko/revanced-manager/issues/1223)) ([0b0ba21](0b0ba21)) * release builds not working properly ([d2dcd42](d2dcd42)) * remove misc.xml and kotlinc.xml ([1f8341a](1f8341a)) * run blocking IO operations in the correct context ([535efa3](535efa3)) * serialization not working ([1331479](1331479)) * sources screen being misaligned during transitions ([149c8cc](149c8cc)) * specify `multithreadingDexFileWriter` in `PatcherOptions` ([ReVanced#1402](https://github.com/BenjaminHalko/revanced-manager/issues/1402)) ([12b00e5](12b00e5)) * typo in string name `import_keystore_description` ([ReVanced#1273](https://github.com/BenjaminHalko/revanced-manager/issues/1273)) ([6f2ca5b](6f2ca5b)) * **ui:** make entire patches view button selectable ([ReVanced#1271](https://github.com/BenjaminHalko/revanced-manager/issues/1271)) ([e0f8d06](e0f8d06)) * universal patches not selectable ([c6ac898](c6ac898)) * Updates popup shows incorrect names ([ReVanced#1283](https://github.com/BenjaminHalko/revanced-manager/issues/1283)) ([65377ff](65377ff)) * use correct `getViewModel` ([1be9c9c](1be9c9c)) * use correct checksum ([7d887c7](7d887c7)) * use correct classes to determine option type ([abf4d91](abf4d91)) * use correct directory ([3b65cd0](3b65cd0)) * use i18n translation for installer page ([72fd24e](72fd24e)) * use ReVanced ring logo in about section ([ReVanced#1302](https://github.com/BenjaminHalko/revanced-manager/issues/1302)) ([f79320c](f79320c)) * use upsert when modifying installed apps ([9df98ed](9df98ed)) ### Features * **about screen:** complete about screen ([fec8c0c](fec8c0c)) * add checkboxes to the downloaded apps page ([e70c10a](e70c10a)) * add patch bundle info screen ([ReVanced#55](https://github.com/BenjaminHalko/revanced-manager/issues/55)) ([21d99a1](21d99a1)) * add patches selector bottom sheet ([ReVanced#1360](https://github.com/BenjaminHalko/revanced-manager/issues/1360)) ([5762859](5762859)) * add toast feedback to the bundle update button ([607d8b6](607d8b6)) * add user agent ([ReVanced#1382](https://github.com/BenjaminHalko/revanced-manager/issues/1382)) ([212e55f](212e55f)) * advanced settings page with device info ([ReVanced#51](https://github.com/BenjaminHalko/revanced-manager/issues/51)) ([453f4da](453f4da)) * allow user to save logs ([d9d83df](d9d83df)) * animate the arrow button ([4868c45](4868c45)) * app downloader ([ReVanced#43](https://github.com/BenjaminHalko/revanced-manager/issues/43)) ([94a4dba](94a4dba)) * app selector screen ([54f0a69](54f0a69)) * **app-selector:** show patchable installed apps first ([ReVanced#1496](https://github.com/BenjaminHalko/revanced-manager/issues/1496)) ([d55abf5](d55abf5)) * armv7 warning ([8f54495](8f54495)) * backend ([e5d898f](e5d898f)) * better installer ui ([ReVanced#29](https://github.com/BenjaminHalko/revanced-manager/issues/29)) ([399fc98](399fc98)) * **bundles tab:** add BackHandler ([757840b](757840b)) * change appID and name of debug builds ([4cb4ce2](4cb4ce2)) * **Changelogs:** overall improvement ([ReVanced#1429](https://github.com/BenjaminHalko/revanced-manager/issues/1429)) ([1a83315](1a83315)) * check for updates on startup ([ReVanced#1462](https://github.com/BenjaminHalko/revanced-manager/issues/1462)) ([1dc41ba](1dc41ba)) * contributors screen ([ReVanced#42](https://github.com/BenjaminHalko/revanced-manager/issues/42)) ([0dccb8c](0dccb8c)) * **Contributors Screen:** implement design from Figma ([ReVanced#1465](https://github.com/BenjaminHalko/revanced-manager/issues/1465)) ([62a5fce](62a5fce)) * Dashboard Screen ([ReVanced#18](https://github.com/BenjaminHalko/revanced-manager/issues/18)) ([9065c0d](9065c0d)) * disable changing patches selection by default ([ReVanced#1132](https://github.com/BenjaminHalko/revanced-manager/issues/1132)) ([c400619](c400619)) * disable filter chips when there are no patches ([5d3b963](5d3b963)) * download apps in patcher screen ([ReVanced#73](https://github.com/BenjaminHalko/revanced-manager/issues/73)) ([aec8cec](aec8cec)) * experimental patches setting ([9dd74f1](9dd74f1)) * filter options for patches ([6309e8b](6309e8b)) * finish implementing the sources system ([ReVanced#70](https://github.com/BenjaminHalko/revanced-manager/issues/70)) ([379ce91](379ce91)) * hide tabs when 1 bundle is used ([ffa8d9c](ffa8d9c)) * hide unfinished pages in release mode ([f5b3b29](f5b3b29)) * implement DI ([57e2632](57e2632)) * implement navigation ([9536cdc](9536cdc)) * implement Submit Issue button ([ReVanced#1276](https://github.com/BenjaminHalko/revanced-manager/issues/1276)) ([cf71ea2](cf71ea2)) * improve accessibility ([ReVanced#64](https://github.com/BenjaminHalko/revanced-manager/issues/64)) ([cd2587b](cd2587b)) * improve bundle dialog UI ([1707a96](1707a96)) * improve keystore UI and UX ([ReVanced#52](https://github.com/BenjaminHalko/revanced-manager/issues/52)) ([aa02e9f](aa02e9f)) * improve patcher UI ([ReVanced#1494](https://github.com/BenjaminHalko/revanced-manager/issues/1494)) ([3232bb1](3232bb1)) * improved compose stability ([fcb75dd](fcb75dd)) * improved dashboard screen ([f1656c6](f1656c6)) * in-app updater ([ReVanced#25](https://github.com/BenjaminHalko/revanced-manager/issues/25)) ([a4842c0](a4842c0)) * initialize project ([b372f7e](b372f7e)) * **installer:** adjust arrow icon size ([39caad1](39caad1)) * **installer:** adjust step icon size and alignment ([6437f7b](6437f7b)) * **installer:** apk signing and installation ([52ab793](52ab793)) * **installer:** redesign utility options ([ReVanced#1062](https://github.com/BenjaminHalko/revanced-manager/issues/1062)) ([b77d46b](b77d46b)) * **installer:** sign apk in patcher worker ([172604f](172604f)) * **Installer:** use BottomAppBar ([ReVanced#1428](https://github.com/BenjaminHalko/revanced-manager/issues/1428)) ([3c57762](3c57762)) * integrate revanced patcher ([ReVanced#22](https://github.com/BenjaminHalko/revanced-manager/issues/22)) ([4048792](4048792)) * keystore import/export ([ReVanced#30](https://github.com/BenjaminHalko/revanced-manager/issues/30)) ([919b6b7](919b6b7)) * **koin:** use the android logger ([7ce4de7](7ce4de7)) * licenses screen ([ReVanced#47](https://github.com/BenjaminHalko/revanced-manager/issues/47)) ([6b7143d](6b7143d)) * make bundles selectable ([ReVanced#1237](https://github.com/BenjaminHalko/revanced-manager/issues/1237)) ([42e0346](42e0346)) * more info for the select from application screen ([ReVanced#81](https://github.com/BenjaminHalko/revanced-manager/issues/81)) ([3cfa4ea](3cfa4ea)) * **NotificationCard:** rewrite & consistent usage ([ReVanced#1426](https://github.com/BenjaminHalko/revanced-manager/issues/1426)) ([7741394](7741394)) * patch apps without internet ([ReVanced#1114](https://github.com/BenjaminHalko/revanced-manager/issues/1114)) ([f90f6e8](f90f6e8)) * patch bundle sources system ([ReVanced#24](https://github.com/BenjaminHalko/revanced-manager/issues/24)) ([c22371e](c22371e)) * patch options ([ReVanced#45](https://github.com/BenjaminHalko/revanced-manager/issues/45)) ([01fd4c8](01fd4c8)) * patch options UI ([ReVanced#80](https://github.com/BenjaminHalko/revanced-manager/issues/80)) ([7aea947](7aea947)) * **patch-selector:** default patches selection ([ReVanced#1272](https://github.com/BenjaminHalko/revanced-manager/issues/1272)) ([f78b56e](f78b56e)) * **patch-selector:** remove TODO about an unplanned feature ([5290713](5290713)) * patches selector screen ([4c3dbbd](4c3dbbd)) * prereleases ([9e344a9](9e344a9)) * ProGuard ([9591f4e](9591f4e)) * Purple default theme ([ReVanced#1601](https://github.com/BenjaminHalko/revanced-manager/issues/1601)) ([d9d7b98](d9d7b98)) * remember patch options ([ReVanced#1449](https://github.com/BenjaminHalko/revanced-manager/issues/1449)) ([7fe4724](7fe4724)) * remove dead help icons ([ca3c9af](ca3c9af)) * rename package to `app.revanced.manager` ([27426b1](27426b1)) * rename ViewModels for consistency ([e088d05](e088d05)) * ReVanced theme colors ([955e7a4](955e7a4)) * root installation ([ReVanced#1243](https://github.com/BenjaminHalko/revanced-manager/issues/1243)) ([bf10af2](bf10af2)) * save patch options and selected patches in bundle ([ReVanced#50](https://github.com/BenjaminHalko/revanced-manager/issues/50)) ([8dd8f88](8dd8f88)) * save patch selection using room db ([ReVanced#38](https://github.com/BenjaminHalko/revanced-manager/issues/38)) ([923ce74](923ce74)) * Scrollbars ([ReVanced#1479](https://github.com/BenjaminHalko/revanced-manager/issues/1479)) ([36c8f59](36c8f59)) * Select bundle type before adding bundle ([ReVanced#1490](https://github.com/BenjaminHalko/revanced-manager/issues/1490)) ([aa6e612](aa6e612)) * selected app info page ([ReVanced#1395](https://github.com/BenjaminHalko/revanced-manager/issues/1395)) ([c3af6ac](c3af6ac)) * settings migration (compose) ([ReVanced#1309](https://github.com/BenjaminHalko/revanced-manager/issues/1309)) ([56a4a70](56a4a70)) * settings screen ([4088ed7](4088ed7)) * **settings screen:** add battery optimization notification ([c332760](c332760)) * **settings screen:** match typography from figma ([9b585c7](9b585c7)) * **settings:** move experimental patches option to advanced ([d8392ad](d8392ad)) * **Settings:** use SettingsListItem consistently and overall improvements ([ReVanced#1427](https://github.com/BenjaminHalko/revanced-manager/issues/1427)) ([25bd91d](25bd91d)) * show installed app in version selector ([61de0b6](61de0b6)) * show stacktrace in installer ui ([ReVanced#36](https://github.com/BenjaminHalko/revanced-manager/issues/36)) ([5681c91](5681c91)) * show toast when no patches are selected ([65f8d38](65f8d38)) * splash screen ([49f9dfc](49f9dfc)) * store patched apps ([ReVanced#79](https://github.com/BenjaminHalko/revanced-manager/issues/79)) ([a0b9255](a0b9255)) * switch to Preferences DataStore ([ReVanced#60](https://github.com/BenjaminHalko/revanced-manager/issues/60)) ([879884a](879884a)) * switch to the new api ([ReVanced#75](https://github.com/BenjaminHalko/revanced-manager/issues/75)) ([3f059d7](3f059d7)) * **Update Screen:** changelogs & handle states ([ReVanced#1464](https://github.com/BenjaminHalko/revanced-manager/issues/1464)) ([bd9778a](bd9778a)) * **update screen:** complete main update screen ([ea4247c](ea4247c)) * updater changelogs ([ReVanced#48](https://github.com/BenjaminHalko/revanced-manager/issues/48)) ([fe5e191](fe5e191)) * updater UI and code improvements ([ReVanced#1597](https://github.com/BenjaminHalko/revanced-manager/issues/1597)) ([b7cb6b9](b7cb6b9)) * Use correct casing in module description ([ac561e7](ac561e7)) * use revanced api for changelogs ([608bac6](608bac6)) ### Reverts * downgrade Kotlin to 1.8.21 ([37e177b](37e177b))

# [1.9.0-dev.1](v1.8.0...v1.9.0-dev.1) (2024-01-23) ### Bug Fixes * broken logo in about page on release builds ([4c1ad86](4c1ad86)) * buildfile syntax ([ReVanced#66](https://github.com/BenjaminHalko/revanced-manager/issues/66)) ([b472a36](b472a36)) * bundles not loading on Android 14 ([18cfb56](18cfb56)) * contributors screen fix ([ReVanced#1256](https://github.com/BenjaminHalko/revanced-manager/issues/1256)) ([9408857](9408857)) * delete temporary files ([ReVanced#1341](https://github.com/BenjaminHalko/revanced-manager/issues/1341)) ([723f9cd](723f9cd)) * **deps:** use correct work-runtime version string ([2bb51c1](2bb51c1)) * disable `WebView` history ([ReVanced#1278](https://github.com/BenjaminHalko/revanced-manager/issues/1278)) ([a86923a](a86923a)) * don't store app list in parcel ([55f2256](55f2256)) * dont crash when the bundle cannot be downloaded ([93f3e27](93f3e27)) * exclude x86 aapt2 binary from release builds ([ReVanced#1126](https://github.com/BenjaminHalko/revanced-manager/issues/1126)) ([381daff](381daff)) * gradlew permissions on unix ([cb0150a](cb0150a)) * handle exceptions when checking for bundle updates ([32e8a37](32e8a37)) * hide patch button ([ReVanced#1284](https://github.com/BenjaminHalko/revanced-manager/issues/1284)) ([5aefb3b](5aefb3b)) * **installer:** make the correct column scrollable ([1eac42d](1eac42d)) * **installer:** progress tracking ([272d911](272d911)) * **installer:** properly track worker state ([ReVanced#32](https://github.com/BenjaminHalko/revanced-manager/issues/32)) ([971277e](971277e)) * **installer:** save step incorrectly being marked as completed ([18cbe51](18cbe51)) * **installer:** sign and install on threads ([4ae9904](4ae9904)) * **installer:** use correct bg colour for dialog ([7525e52](7525e52)) * **installer:** use correct elevation level ([d9953b1](d9953b1)) * jvm signature clash error ([4b12ae1](4b12ae1)) * library info not being embedded ([299aaa2](299aaa2)) * load patch bundles earlier ([9cab919](9cab919)) * minify crash on building release ([ReVanced#1245](https://github.com/BenjaminHalko/revanced-manager/issues/1245)) ([b4dfcf1](b4dfcf1)) * more android 34 fixes ([64ec73d](64ec73d)) * option state crash ([ReVanced#1456](https://github.com/BenjaminHalko/revanced-manager/issues/1456)) ([5fff0a2](5fff0a2)) * overlapping issue in application selection page ([ReVanced#1128](https://github.com/BenjaminHalko/revanced-manager/issues/1128)) ([372ce17](372ce17)) * parcel error for nullable types ([2bd8463](2bd8463)) * pass worker inputs without serialization ([ReVanced#44](https://github.com/BenjaminHalko/revanced-manager/issues/44)) ([4302ea8](4302ea8)) * patch options reset button being broken ([0b9889e](0b9889e)) * **patcher:** add notification and wakelock to worker; chore: add app icon ([b8a51d3](b8a51d3)) * patches not being reloaded ([9586a9c](9586a9c)) * **patches selector:** copy the selected patches list ([762bfa8](762bfa8)) * perform selected app operations in the correct order ([cc89784](cc89784)) * permission error when using installed app ([f6563b2](f6563b2)) * progress bar not updating ([f38b31a](f38b31a)) * providers.gradleProperty ([ReVanced#1223](https://github.com/BenjaminHalko/revanced-manager/issues/1223)) ([0b0ba21](0b0ba21)) * release builds not working properly ([d2dcd42](d2dcd42)) * remove misc.xml and kotlinc.xml ([1f8341a](1f8341a)) * run blocking IO operations in the correct context ([535efa3](535efa3)) * serialization not working ([1331479](1331479)) * sources screen being misaligned during transitions ([149c8cc](149c8cc)) * specify `multithreadingDexFileWriter` in `PatcherOptions` ([ReVanced#1402](https://github.com/BenjaminHalko/revanced-manager/issues/1402)) ([12b00e5](12b00e5)) * typo in string name `import_keystore_description` ([ReVanced#1273](https://github.com/BenjaminHalko/revanced-manager/issues/1273)) ([6f2ca5b](6f2ca5b)) * **ui:** make entire patches view button selectable ([ReVanced#1271](https://github.com/BenjaminHalko/revanced-manager/issues/1271)) ([e0f8d06](e0f8d06)) * universal patches not selectable ([c6ac898](c6ac898)) * Updates popup shows incorrect names ([ReVanced#1283](https://github.com/BenjaminHalko/revanced-manager/issues/1283)) ([65377ff](65377ff)) * use correct `getViewModel` ([1be9c9c](1be9c9c)) * use correct checksum ([7d887c7](7d887c7)) * use correct classes to determine option type ([abf4d91](abf4d91)) * use correct directory ([3b65cd0](3b65cd0)) * use i18n translation for installer page ([72fd24e](72fd24e)) * use ReVanced ring logo in about section ([ReVanced#1302](https://github.com/BenjaminHalko/revanced-manager/issues/1302)) ([f79320c](f79320c)) * use upsert when modifying installed apps ([9df98ed](9df98ed)) ### Features * **about screen:** complete about screen ([fec8c0c](fec8c0c)) * add checkboxes to the downloaded apps page ([e70c10a](e70c10a)) * add patch bundle info screen ([ReVanced#55](https://github.com/BenjaminHalko/revanced-manager/issues/55)) ([21d99a1](21d99a1)) * add patches selector bottom sheet ([ReVanced#1360](https://github.com/BenjaminHalko/revanced-manager/issues/1360)) ([5762859](5762859)) * add toast feedback to the bundle update button ([607d8b6](607d8b6)) * add user agent ([ReVanced#1382](https://github.com/BenjaminHalko/revanced-manager/issues/1382)) ([212e55f](212e55f)) * advanced settings page with device info ([ReVanced#51](https://github.com/BenjaminHalko/revanced-manager/issues/51)) ([453f4da](453f4da)) * allow user to save logs ([d9d83df](d9d83df)) * animate the arrow button ([4868c45](4868c45)) * app downloader ([ReVanced#43](https://github.com/BenjaminHalko/revanced-manager/issues/43)) ([94a4dba](94a4dba)) * app selector screen ([54f0a69](54f0a69)) * **app-selector:** show patchable installed apps first ([ReVanced#1496](https://github.com/BenjaminHalko/revanced-manager/issues/1496)) ([d55abf5](d55abf5)) * armv7 warning ([8f54495](8f54495)) * backend ([e5d898f](e5d898f)) * better installer ui ([ReVanced#29](https://github.com/BenjaminHalko/revanced-manager/issues/29)) ([399fc98](399fc98)) * **bundles tab:** add BackHandler ([757840b](757840b)) * change appID and name of debug builds ([4cb4ce2](4cb4ce2)) * **Changelogs:** overall improvement ([ReVanced#1429](https://github.com/BenjaminHalko/revanced-manager/issues/1429)) ([1a83315](1a83315)) * check for updates on startup ([ReVanced#1462](https://github.com/BenjaminHalko/revanced-manager/issues/1462)) ([1dc41ba](1dc41ba)) * contributors screen ([ReVanced#42](https://github.com/BenjaminHalko/revanced-manager/issues/42)) ([0dccb8c](0dccb8c)) * **Contributors Screen:** implement design from Figma ([ReVanced#1465](https://github.com/BenjaminHalko/revanced-manager/issues/1465)) ([62a5fce](62a5fce)) * Dashboard Screen ([ReVanced#18](https://github.com/BenjaminHalko/revanced-manager/issues/18)) ([9065c0d](9065c0d)) * disable changing patches selection by default ([ReVanced#1132](https://github.com/BenjaminHalko/revanced-manager/issues/1132)) ([c400619](c400619)) * disable filter chips when there are no patches ([5d3b963](5d3b963)) * download apps in patcher screen ([ReVanced#73](https://github.com/BenjaminHalko/revanced-manager/issues/73)) ([aec8cec](aec8cec)) * experimental patches setting ([9dd74f1](9dd74f1)) * filter options for patches ([6309e8b](6309e8b)) * finish implementing the sources system ([ReVanced#70](https://github.com/BenjaminHalko/revanced-manager/issues/70)) ([379ce91](379ce91)) * hide tabs when 1 bundle is used ([ffa8d9c](ffa8d9c)) * hide unfinished pages in release mode ([f5b3b29](f5b3b29)) * implement DI ([57e2632](57e2632)) * implement navigation ([9536cdc](9536cdc)) * implement Submit Issue button ([ReVanced#1276](https://github.com/BenjaminHalko/revanced-manager/issues/1276)) ([cf71ea2](cf71ea2)) * improve accessibility ([ReVanced#64](https://github.com/BenjaminHalko/revanced-manager/issues/64)) ([cd2587b](cd2587b)) * improve bundle dialog UI ([1707a96](1707a96)) * improve keystore UI and UX ([ReVanced#52](https://github.com/BenjaminHalko/revanced-manager/issues/52)) ([aa02e9f](aa02e9f)) * improve patcher UI ([ReVanced#1494](https://github.com/BenjaminHalko/revanced-manager/issues/1494)) ([3232bb1](3232bb1)) * improved compose stability ([fcb75dd](fcb75dd)) * improved dashboard screen ([f1656c6](f1656c6)) * in-app updater ([ReVanced#25](https://github.com/BenjaminHalko/revanced-manager/issues/25)) ([a4842c0](a4842c0)) * initialize project ([b372f7e](b372f7e)) * **installer:** adjust arrow icon size ([39caad1](39caad1)) * **installer:** adjust step icon size and alignment ([6437f7b](6437f7b)) * **installer:** apk signing and installation ([52ab793](52ab793)) * **installer:** redesign utility options ([ReVanced#1062](https://github.com/BenjaminHalko/revanced-manager/issues/1062)) ([b77d46b](b77d46b)) * **installer:** sign apk in patcher worker ([172604f](172604f)) * **Installer:** use BottomAppBar ([ReVanced#1428](https://github.com/BenjaminHalko/revanced-manager/issues/1428)) ([3c57762](3c57762)) * integrate revanced patcher ([ReVanced#22](https://github.com/BenjaminHalko/revanced-manager/issues/22)) ([4048792](4048792)) * keystore import/export ([ReVanced#30](https://github.com/BenjaminHalko/revanced-manager/issues/30)) ([919b6b7](919b6b7)) * **koin:** use the android logger ([7ce4de7](7ce4de7)) * licenses screen ([ReVanced#47](https://github.com/BenjaminHalko/revanced-manager/issues/47)) ([6b7143d](6b7143d)) * make bundles selectable ([ReVanced#1237](https://github.com/BenjaminHalko/revanced-manager/issues/1237)) ([42e0346](42e0346)) * more info for the select from application screen ([ReVanced#81](https://github.com/BenjaminHalko/revanced-manager/issues/81)) ([3cfa4ea](3cfa4ea)) * **NotificationCard:** rewrite & consistent usage ([ReVanced#1426](https://github.com/BenjaminHalko/revanced-manager/issues/1426)) ([7741394](7741394)) * patch apps without internet ([ReVanced#1114](https://github.com/BenjaminHalko/revanced-manager/issues/1114)) ([f90f6e8](f90f6e8)) * patch bundle sources system ([ReVanced#24](https://github.com/BenjaminHalko/revanced-manager/issues/24)) ([c22371e](c22371e)) * patch options ([ReVanced#45](https://github.com/BenjaminHalko/revanced-manager/issues/45)) ([01fd4c8](01fd4c8)) * patch options UI ([ReVanced#80](https://github.com/BenjaminHalko/revanced-manager/issues/80)) ([7aea947](7aea947)) * **patch-selector:** default patches selection ([ReVanced#1272](https://github.com/BenjaminHalko/revanced-manager/issues/1272)) ([f78b56e](f78b56e)) * **patch-selector:** remove TODO about an unplanned feature ([5290713](5290713)) * patches selector screen ([4c3dbbd](4c3dbbd)) * prereleases ([9e344a9](9e344a9)) * ProGuard ([9591f4e](9591f4e)) * Purple default theme ([ReVanced#1601](https://github.com/BenjaminHalko/revanced-manager/issues/1601)) ([d9d7b98](d9d7b98)) * remember patch options ([ReVanced#1449](https://github.com/BenjaminHalko/revanced-manager/issues/1449)) ([7fe4724](7fe4724)) * remove dead help icons ([ca3c9af](ca3c9af)) * rename package to `app.revanced.manager` ([27426b1](27426b1)) * rename ViewModels for consistency ([e088d05](e088d05)) * ReVanced theme colors ([955e7a4](955e7a4)) * root installation ([ReVanced#1243](https://github.com/BenjaminHalko/revanced-manager/issues/1243)) ([bf10af2](bf10af2)) * save patch options and selected patches in bundle ([ReVanced#50](https://github.com/BenjaminHalko/revanced-manager/issues/50)) ([8dd8f88](8dd8f88)) * save patch selection using room db ([ReVanced#38](https://github.com/BenjaminHalko/revanced-manager/issues/38)) ([923ce74](923ce74)) * Scrollbars ([ReVanced#1479](https://github.com/BenjaminHalko/revanced-manager/issues/1479)) ([36c8f59](36c8f59)) * Select bundle type before adding bundle ([ReVanced#1490](https://github.com/BenjaminHalko/revanced-manager/issues/1490)) ([aa6e612](aa6e612)) * selected app info page ([ReVanced#1395](https://github.com/BenjaminHalko/revanced-manager/issues/1395)) ([c3af6ac](c3af6ac)) * settings migration (compose) ([ReVanced#1309](https://github.com/BenjaminHalko/revanced-manager/issues/1309)) ([56a4a70](56a4a70)) * settings screen ([4088ed7](4088ed7)) * **settings screen:** add battery optimization notification ([c332760](c332760)) * **settings screen:** match typography from figma ([9b585c7](9b585c7)) * **settings:** move experimental patches option to advanced ([d8392ad](d8392ad)) * **Settings:** use SettingsListItem consistently and overall improvements ([ReVanced#1427](https://github.com/BenjaminHalko/revanced-manager/issues/1427)) ([25bd91d](25bd91d)) * show installed app in version selector ([61de0b6](61de0b6)) * show stacktrace in installer ui ([ReVanced#36](https://github.com/BenjaminHalko/revanced-manager/issues/36)) ([5681c91](5681c91)) * show toast when no patches are selected ([65f8d38](65f8d38)) * store patched apps ([ReVanced#79](https://github.com/BenjaminHalko/revanced-manager/issues/79)) ([a0b9255](a0b9255)) * switch to Preferences DataStore ([ReVanced#60](https://github.com/BenjaminHalko/revanced-manager/issues/60)) ([879884a](879884a)) * switch to the new api ([ReVanced#75](https://github.com/BenjaminHalko/revanced-manager/issues/75)) ([3f059d7](3f059d7)) * **Update Screen:** changelogs & handle states ([ReVanced#1464](https://github.com/BenjaminHalko/revanced-manager/issues/1464)) ([bd9778a](bd9778a)) * **update screen:** complete main update screen ([ea4247c](ea4247c)) * updater changelogs ([ReVanced#48](https://github.com/BenjaminHalko/revanced-manager/issues/48)) ([fe5e191](fe5e191)) * updater UI and code improvements ([ReVanced#1597](https://github.com/BenjaminHalko/revanced-manager/issues/1597)) ([b7cb6b9](b7cb6b9)) * Use correct casing in module description ([ac561e7](ac561e7)) * use revanced api for changelogs ([608bac6](608bac6)) ### Reverts * downgrade Kotlin to 1.8.21 ([37e177b](37e177b))

BenjaminHalko added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Sep 20, 2023

BenjaminHalko force-pushed the compose-dev branch from 846b712 to 36de61a Compare September 21, 2023 03:14

validcube requested changes Sep 21, 2023

View reviewed changes

.github/workflows/pr-build.yml Outdated Show resolved Hide resolved

.github/workflows/release.yml Outdated Show resolved Hide resolved

app/build.gradle.kts Outdated Show resolved Hide resolved

BenjaminHalko force-pushed the hide-patch-button branch from 65a3d78 to 6e19bdf Compare September 21, 2023 15:51

fix: hide patch button

6e19bdf

BenjaminHalko requested a review from validcube September 21, 2023 15:52

Update PatchesSelectorViewModel.kt

d71d016

Axelen123 requested changes Sep 21, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatchesSelectorScreen.kt Outdated Show resolved Hide resolved

BenjaminHalko added 2 commits September 21, 2023 12:21

keep comment

5170774

add extra line

eda3ceb

BenjaminHalko requested a review from Axelen123 September 21, 2023 19:41

Axelen123 requested changes Sep 22, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatchesSelectorScreen.kt Outdated Show resolved Hide resolved

BenjaminHalko force-pushed the hide-patch-button branch from 57e70ce to eda3ceb Compare September 25, 2023 23:47

oSumAtrIX marked this pull request as draft October 1, 2023 17:08

BenjaminHalko added 2 commits October 14, 2023 10:59

Merge branch 'compose-dev' into hide-patch-button

f94e394

Toggle visibility

f7d44e1

Hide patch button

ce1b79c

BenjaminHalko marked this pull request as ready for review October 14, 2023 20:36

BenjaminHalko requested review from PalmDevs and removed request for validcube October 14, 2023 20:41

BenjaminHalko and others added 2 commits October 14, 2023 14:01

Set showPatchButton correctly

5b33d25

Merge branch 'compose-dev' into hide-patch-button

4a38745

PalmDevs approved these changes Oct 16, 2023

View reviewed changes

BenjaminHalko merged commit 5aefb3b into ReVanced:compose-dev Oct 16, 2023
1 check passed

BenjaminHalko deleted the hide-patch-button branch October 16, 2023 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hide patch button #1284

fix: hide patch button #1284

BenjaminHalko commented Sep 20, 2023

validcube left a comment •

edited

Loading

BenjaminHalko commented Sep 21, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023 •

edited

Loading

BenjaminHalko commented Sep 25, 2023 •

edited

Loading

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023 •

edited

Loading

Axelen123 commented Sep 26, 2023

PalmDevs commented Sep 26, 2023

BenjaminHalko commented Oct 14, 2023

BenjaminHalko commented Oct 14, 2023

PalmDevs commented Oct 14, 2023

BenjaminHalko commented Oct 14, 2023 •

edited

Loading

BenjaminHalko commented Oct 14, 2023

BenjaminHalko commented Oct 16, 2023

PalmDevs commented Oct 16, 2023

Axelen123 commented Oct 16, 2023

PalmDevs left a comment

fix: hide patch button #1284

fix: hide patch button #1284

Conversation

BenjaminHalko commented Sep 20, 2023

validcube left a comment • edited Loading

Choose a reason for hiding this comment

BenjaminHalko commented Sep 21, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023 • edited Loading

BenjaminHalko commented Sep 25, 2023 • edited Loading

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

Ushie commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023

BenjaminHalko commented Sep 25, 2023 • edited Loading

Axelen123 commented Sep 26, 2023

PalmDevs commented Sep 26, 2023

BenjaminHalko commented Oct 14, 2023

BenjaminHalko commented Oct 14, 2023

PalmDevs commented Oct 14, 2023

BenjaminHalko commented Oct 14, 2023 • edited Loading

BenjaminHalko commented Oct 14, 2023

BenjaminHalko commented Oct 16, 2023

PalmDevs commented Oct 16, 2023

Axelen123 commented Oct 16, 2023

PalmDevs left a comment

Choose a reason for hiding this comment

validcube left a comment •

edited

Loading

Ushie commented Sep 25, 2023 •

edited

Loading

BenjaminHalko commented Sep 25, 2023 •

edited

Loading

BenjaminHalko commented Sep 25, 2023 •

edited

Loading

BenjaminHalko commented Oct 14, 2023 •

edited

Loading