Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve documentation #1411
base: compose-dev
Are you sure you want to change the base?
docs: Improve documentation #1411
Changes from all commits
e7b9486
676eb1e
67603f6
85c6e72
26b9652
830a666
949b1da
e0dfbaf
9b9525e
f732df1
a503f48
a280fc2
cd5787a
2f0cdff
b8378fb
259f763
d58fd96
8a3d163
7bf1a5a
3c083ed
2f782b4
98747f4
1f5331d
8acdc17
0d2d879
a70ad3d
1877408
7b49af2
cf9a14c
d06fb08
f14b697
a3c48d1
07ee005
891fb57
10815c8
a8682d6
af49457
94eb893
dcf51c1
2f31fc7
0419b2f
bc09af9
944b57c
2a3395c
d32a213
35996b6
1521d21
62bb0d3
3c56db4
94de170
ace6701
adf5f9f
a290369
db4ce6b
3bbad15
05bf940
8442bf2
911201a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "Contribution guidelines" or "ReVanced Manager contribution guidelines"
the second one is consistent with ReVanced Patches repository
https://github.com/ReVanced/revanced-patches/blob/docs/CONTRIBUTING.md#-revanced-patches-contribution-guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the second one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably link to the actual file instead of the table of contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'an certain requirements had to be met' is grammatically incorrect. It should be 'certain requirements have to be met.'
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'These requirement(s) are not required to be met' is awkwardly phrased. It should be 'These requirements are optional.'
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May have to be rewritten for Compose version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭 @BenjaminHalko what happen to steps number 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still incomplete