Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add haptic feedback #1457

Merged
merged 8 commits into from
Nov 6, 2024
Merged

feat: add haptic feedback #1457

merged 8 commits into from
Nov 6, 2024

Conversation

BenjaminHalko
Copy link
Member

Adds haptic feedback to compose

@BenjaminHalko BenjaminHalko added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Nov 2, 2023
@oSumAtrIX
Copy link
Member

Is this ready for review?

@BenjaminHalko BenjaminHalko marked this pull request as ready for review November 22, 2023 00:34
@BenjaminHalko BenjaminHalko marked this pull request as draft November 22, 2023 01:44
Copy link
Member

@Ushie Ushie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had this review pending for a month's time, apparently I never clicked submit review..

@BenjaminHalko BenjaminHalko marked this pull request as ready for review December 16, 2023 21:28
@oSumAtrIX oSumAtrIX requested a review from Ushie July 28, 2024 20:45
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many unrelated formatting changes in files that don't have anything to do with haptics?

@Ushie
Copy link
Member

Ushie commented Jul 29, 2024

Why are there so many unrelated formatting changes in files that don't have anything to do with haptics?

Didn't notice, I installed KTLint and I guess these were files that I visited

@Ushie Ushie merged commit b4c37e6 into compose-dev Nov 6, 2024
1 check passed
@Ushie Ushie deleted the feat/haptic-compose branch November 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants