-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prereleases #1653
Draft
BenjaminHalko
wants to merge
10
commits into
compose-dev
Choose a base branch
from
feat/compose-prereleases
base: compose-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: prereleases #1653
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e344a9
feat: prereleases
BenjaminHalko 906ff56
Use Node 20
BenjaminHalko e753bfc
Update release-build.yml
BenjaminHalko a1bf955
Update build.gradle.kts
BenjaminHalko 1974659
Updated build
BenjaminHalko d047ae9
Updated build again
BenjaminHalko 0f3ae5f
Updated build again, again.
BenjaminHalko adfbc64
Update pr-build.yml
BenjaminHalko fb3681d
Update build.gradle.kts
BenjaminHalko 9e4f1c2
Updated build again, again, again
BenjaminHalko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ | |
.externalNativeBuild | ||
.cxx | ||
local.properties | ||
|
||
/node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
{ | ||
"branches": [ | ||
"main", | ||
{ | ||
"name": "dev", | ||
"prerelease": true | ||
} | ||
], | ||
"plugins": [ | ||
[ | ||
"@semantic-release/commit-analyzer", { | ||
"releaseRules": [ | ||
{ "type": "build", "scope": "Needs bump", "release": "patch" } | ||
] | ||
} | ||
], | ||
"@semantic-release/changelog", | ||
"@semantic-release/release-notes-generator", | ||
"gradle-semantic-release-plugin", | ||
[ | ||
"@semantic-release/git", | ||
{ | ||
"assets": [ | ||
"gradle.properties" | ||
] | ||
} | ||
], | ||
[ | ||
"@semantic-release/github", | ||
{ | ||
"assets": [ | ||
{ | ||
"path": "app/build/outputs/apk/release/revanced-manager*.apk" | ||
} | ||
], | ||
"successComment": false | ||
} | ||
], | ||
[ | ||
"@saithodev/semantic-release-backmerge", | ||
{ | ||
"backmergeBranches": [{"from": "main", "to": "dev"}], | ||
"clearWorkspace": true | ||
} | ||
] | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ plugins { | |
kotlin("plugin.serialization") version "1.9.10" | ||
} | ||
|
||
val (majorVersion, minorVersion, patchVersion, devVersion) = "${project.version}.0".replace("-dev","").split(".") | ||
android { | ||
namespace = "app.revanced.manager" | ||
compileSdk = 34 | ||
|
@@ -16,8 +17,8 @@ android { | |
applicationId = "app.revanced.manager" | ||
minSdk = 26 | ||
targetSdk = 34 | ||
versionCode = 1 | ||
versionName = "0.0.1" | ||
versionName = project.version.toString() | ||
versionCode = (majorVersion.toInt() * 100000000) + (minorVersion.toInt() * 100000) + (patchVersion.toInt() * 100) + devVersion.toInt() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ReVanced Manager v2 will not use the versionCode calculator that v1 uses, it was a mistake The right way is to bump by 1 for each build |
||
resourceConfigurations.addAll(listOf( | ||
"en", | ||
)) | ||
|
@@ -31,16 +32,36 @@ android { | |
} | ||
|
||
release { | ||
if (System.getenv("signingKey") != null) { | ||
signingConfigs { | ||
create("release") { | ||
storeFile = file(System.getenv("signingKey")) | ||
storePassword = System.getenv("keyStorePassword") | ||
keyAlias = System.getenv("keyAlias") | ||
keyPassword = System.getenv("keyPassword") | ||
} | ||
} | ||
Axelen123 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
signingConfig = signingConfigs.getByName("release") | ||
} else { | ||
applicationIdSuffix = ".debug" | ||
resValue("string", "app_name", "ReVanced Manager Debug") | ||
signingConfig = signingConfigs.getByName("debug") | ||
} | ||
if (!project.hasProperty("noProguard")) { | ||
isMinifyEnabled = true | ||
isShrinkResources = true | ||
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro") | ||
} | ||
|
||
if (project.hasProperty("signAsDebug")) { | ||
applicationIdSuffix = ".debug" | ||
resValue("string", "app_name", "ReVanced Manager Debug") | ||
signingConfig = signingConfigs.getByName("debug") | ||
var suffix = "v${project.version}" | ||
if (project.hasProperty("suffix")) { | ||
suffix = "${project.property("suffix")}" | ||
} | ||
applicationVariants.all { | ||
this.outputs | ||
.map { it as com.android.build.gradle.internal.api.BaseVariantOutputImpl } | ||
.forEach { output -> | ||
output.outputFileName = "revanced-manager-${suffix}.apk" | ||
} | ||
} | ||
} | ||
} | ||
|
@@ -89,6 +110,12 @@ kotlin { | |
jvmToolchain(17) | ||
} | ||
|
||
tasks.register("publish") { | ||
group = "Build" | ||
description = "Assemble main outputs for all the variants." | ||
dependsOn("assembleRelease") | ||
} | ||
|
||
dependencies { | ||
|
||
// AndroidX Core | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is proguard disabled?