Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Android 15 #2074

Draft
wants to merge 2 commits into
base: compose-dev
Choose a base branch
from
Draft

feat: Support Android 15 #2074

wants to merge 2 commits into from

Conversation

validcube
Copy link
Member

✨ Support and utilise features from SDK 35

This PR adds support for Vanilla Ice Cream and uses features from it like <nobreak> (https://developer.android.com/about/versions/15/features#line-breaks)

This PR hopes to support and utilise features from Android 15 (hopefully) before the final release of Android.

@validcube validcube self-assigned this Jul 22, 2024
@validcube validcube marked this pull request as draft July 22, 2024 10:59
Comment on lines +46 to +48
<string name="auto_updates_dialog_description">Do you want <nobreak>ReVanced Manager</nobreak> to periodically check for updates for the following components?</string>
<string name="auto_updates_dialog_manager"><nobreak>ReVanced Manager</nobreak></string>
<string name="auto_updates_dialog_patches"><nobreak>ReVanced Patches</nobreak></string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure nobreak works with stringResource?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.. forgot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work if the string is read as an AnnotatedString. Compose does not have this currently, but there are snippets online for it.

@oSumAtrIX oSumAtrIX added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants