Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update English language capitalizations and format #228

Merged
merged 4 commits into from
Sep 20, 2022
Merged

chore: update English language capitalizations and format #228

merged 4 commits into from
Sep 20, 2022

Conversation

PalmDevs
Copy link
Member

No description provided.

assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
assets/i18n/en.json Outdated Show resolved Hide resolved
@ponces ponces requested review from ponces and Aunali321 and removed request for ponces September 19, 2022 10:48
@Aunali321
Copy link
Contributor

Yup agree with you. Please make the changes @PalmDevs .

@PalmDevs
Copy link
Member Author

Checked from Google apps and text in those contexts do not need the capitalization. But sure, I would revert for you

@PalmDevs
Copy link
Member Author

I do half agree on the xxx organization part though

@PalmDevs
Copy link
Member Author

@Aunali321, please review

@Aunali321
Copy link
Contributor

In latest commit card, it should be Update Manager not Update.

@PalmDevs
Copy link
Member Author

PalmDevs commented Sep 20, 2022

Check latest commit, it has Update Manager
Screenshot_20220920-103418_GitHub.png

@PalmDevs
Copy link
Member Author

@ponces May I ask why Mode in Dark Mode needs to be capitalized?

@PalmDevs
Copy link
Member Author

Check latest commit, it has Update Manager Screenshot_20220920-103418_GitHub.png

@Aunali321 Can you review again, and possibly merge?

Update my shitty brain please
@PalmDevs
Copy link
Member Author

@Aunali321 REVIEW LAST TIME PLEASE THX

@Aunali321
Copy link
Contributor

Looks good

@Aunali321
Copy link
Contributor

Thanks!

@Aunali321 Aunali321 merged commit 4c4b694 into ReVanced:flutter Sep 20, 2022
@PalmDevs PalmDevs deleted the patch-1 branch September 20, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants