Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Add donation link to settings about screen #3626

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Sep 7, 2024

Adds a donate link to the settings about screen.

Integration changes

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 0684ab5 into ReVanced:dev Sep 9, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/yt_about_donate branch September 9, 2024 07:21
revanced-bot pushed a commit that referenced this pull request Sep 9, 2024
# [4.14.0-dev.9](v4.14.0-dev.8...v4.14.0-dev.9) (2024-09-09)

### Features

* **YouTube:** Add donation link to settings about screen ([#3626](#3626)) ([0684ab5](0684ab5))
@MarcaDian
Copy link
Contributor

I have a question. You moved the import/export strings to another place, the keys didn't changed, so the translation should be there, but it isn't, and crowdin doesn't have any not approved this strings.
Screenshot_2024-09-17-18-41-56-940-edit_app revanced android youtube

@LisoUseInAIKyrios
Copy link
Contributor Author

The strings were moved because they were not part of the correct patch. Other apps could use the same import/export feature, so it should not be part of any YT specific patch.

Crowdin should automatically use the last strings again, by the translation memory feature. They won't be approved again, but strings are exported with or without approval.

It just needs another sync from crowdin to fix this.

revanced-bot pushed a commit that referenced this pull request Sep 18, 2024
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([#3616](#3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([#3628](#3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([#3558](#3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([#3601](#3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([#3582](#3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([#3602](#3602)) ([5998029](5998029))
* Add `Check environment` patch ([#3610](#3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([#3422](#3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([#3647](#3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([#3592](#3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#3570](#3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([#3556](#3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([#3626](#3626)) ([0684ab5](0684ab5))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Sep 18, 2024
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/E85Addict/revanced-patches/issues/3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/E85Addict/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029))
* Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/E85Addict/revanced-patches/issues/3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/E85Addict/revanced-patches/issues/3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/E85Addict/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

### Performance Improvements

* Personal Logo && Add upstream sync ([2e4ef0a](2e4ef0a))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Sep 18, 2024
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/E85Addict/revanced-patches/issues/3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/E85Addict/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029))
* Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/E85Addict/revanced-patches/issues/3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/E85Addict/revanced-patches/issues/3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/E85Addict/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

### Performance Improvements

* Personal Logo && Add upstream sync ([2e4ef0a](2e4ef0a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants