Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube - Spoof client): Allow forcing AVC codec with iOS #3570

Merged
merged 9 commits into from
Aug 22, 2024
Merged

feat(YouTube - Spoof client): Allow forcing AVC codec with iOS #3570

merged 9 commits into from
Aug 22, 2024
+33 −6

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Aug 21, 2024 •
edited
Loading

Allows forcing AVC (aka H.264) with iOS, which might work better or be no different than the typical VP9 and AV1 that iOS uses.

On older devices that lack VP9 and AV1 hardware decoding, this setting is always on even if the settings UI switch is turned off.

Keep in mind that AVC is the oldest codec and you will see higher bandwidth usage and/or decreased video quality compared to VP9 and AV1.

Integration changes

@LisoUseInAIKyrios LisoUseInAIKyrios mentioned this pull request Aug 21, 2024
Merged
@0xrxL
Copy link

0xrxL commented Aug 21, 2024 •
edited
Loading

There's a way to force AV1 instead? In this way the supported devices can always use HDR (when it's available, also on VP9 videos).

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Aug 21, 2024 •
edited
Loading

There's a way to force AV1 instead? In this way the supported devices can always use HDR (when it's available, also on VP9 videos).

It already spoofs to iPhone 15 (which uses AV1), but only spoofs to this if the Android device also supports hardware AV1.

Using AV1 software rendering is awful for battery life so I'm not sure if anyone actually wants that.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Spoof client): Allow forcing AVC1 codec with iOS feat(YouTube - Spoof client): Allow forcing AVC codec with iOS Aug 21, 2024
@7Grn
Copy link

7Grn commented Aug 21, 2024 •
edited
Loading

There's a way to force AV1 instead? In this way the supported devices can always use HDR (when it's available, also on VP9 videos).

It already spoofs to iPhone 15 (which has AV1 hardware support) but only if the Android device also supports hardware AV1.

Using AV1 software rendering is awful for battery life so I'm not sure if anyone actually wants that.

i would be grateful if it were technically possible to provide an option to force AV1, like the AVC1 discussed here. (im using a device with a SnapDragon865/SM8250 SoC that does not have support for AV1 hardware decode)

@kitadai31
Copy link
Contributor

fix: It seems to always use VP9/AV1 if not forced to AVC1

AVC will be used when the device doesn't support VP9 HW decoding

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 1a49d1f into ReVanced:dev Aug 22, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/client_spoof_vp9 branch August 22, 2024 17:48
revanced-bot pushed a commit that referenced this pull request Aug 22, 2024
@semantic-release-bot
chore(release): 4.14.0-dev.1 [skip ci]
6b886a5 
# [4.14.0-dev.1](v4.13.4-dev.2...v4.14.0-dev.1) (2024-08-22)

### Features

* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#3570](#3570)) ([1a49d1f](1a49d1f))
@cyberboh
Copy link

Something broken while compiling resources:

WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_spoof_client_use_ios_summary_off without required default value.
WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_spoof_client_use_ios_summary_on without required default value.
WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_spoof_client_use_ios_title without required default value.

@LisoUseInAIKyrios
Copy link
Contributor Author

It's from the old translated strings that still exist for the removed iOS preference switch.

It should be fixed after the next pull from Crowdin.

For now you can ignore those errors.

zainarbani pushed a commit to zainarbani/revanced-patches that referenced this pull request Aug 26, 2024
@semantic-release-bot
chore(release): 4.14.0-dev.1 [skip ci]
76e3d6a 
# [4.14.0-dev.1](v4.13.4...v4.14.0-dev.1) (2024-08-26)

### Bug Fixes

* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/zainarbani/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube - Spoof Client:** Fix playback by replace streaming data ([70bdc0d](70bdc0d))

### Features

* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/zainarbani/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Sep 9, 2024
@semantic-release-bot
chore(release): 4.14.0-dev.1 [skip ci]
d526fc8 
# [4.14.0-dev.1](v4.13.3...v4.14.0-dev.1) (2024-09-09)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))

### Features

* Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029))
* Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
* **YouTube:** Support versions 19.17 thru 19.30 ([a69c4f3](a69c4f3))
revanced-bot pushed a commit that referenced this pull request Sep 18, 2024
@semantic-release-bot
chore(release): 4.14.0 [skip ci]
5dffd3d 
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([#3616](#3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([#3628](#3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([#3558](#3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([#3601](#3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([#3582](#3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([#3602](#3602)) ([5998029](5998029))
* Add `Check environment` patch ([#3610](#3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([#3422](#3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([#3647](#3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([#3592](#3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#3570](#3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([#3556](#3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([#3626](#3626)) ([0684ab5](0684ab5))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Sep 18, 2024
@semantic-release-bot
chore(release): 4.14.0 [skip ci]
7ae4cbc 
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/E85Addict/revanced-patches/issues/3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/E85Addict/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029))
* Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/E85Addict/revanced-patches/issues/3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/E85Addict/revanced-patches/issues/3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/E85Addict/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

### Performance Improvements

* Personal Logo && Add upstream sync ([2e4ef0a](2e4ef0a))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Sep 18, 2024
@semantic-release-bot
chore(release): 4.14.0 [skip ci]
9cebaa2 
# [4.14.0](v4.13.3...v4.14.0) (2024-09-18)

### Bug Fixes

* **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8))
* **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/E85Addict/revanced-patches/issues/3628)) ([66e7e33](66e7e33))
* **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771))
* **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82))
* **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f))
* **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1))
* **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/E85Addict/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7))

### Features

* Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029))
* Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf))
* **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599))
* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3))
* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49))
* **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/E85Addict/revanced-patches/issues/3647)) ([33fc090](33fc090))
* **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351))
* **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f))
* **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/E85Addict/revanced-patches/issues/3556)) ([12f6f19](12f6f19))
* **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/E85Addict/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

### Performance Improvements

* Personal Logo && Add upstream sync ([2e4ef0a](2e4ef0a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX left review comments

@kitadai31 kitadai31 kitadai31 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LisoUseInAIKyrios @0xrxL @7Grn @kitadai31 @cyberboh @oSumAtrIX