Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(youtube): app name option of the custom-branding patch is marked as required #594

Closed
3 tasks done
Axelen123 opened this issue Jul 15, 2023 · 0 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@Axelen123
Copy link
Member

Type

Other

Bug description

The required attribute can be used by frontends to determine if it is safe to proceed with the default value.
The app name option of the custom-branding patch is marked as required even though it is not required to change it.

Steps to reproduce

N/A

Relevant log output

N/A

Screenshots or videos

N/A

Solution

The option should not be marked as required.

Additional context

private var appName: String? by option(
PatchOption.StringOption(
key = "appName",
default = "YouTube ReVanced",
title = "Application Name",
description = "The name of the application it will show on your home screen.",
required = true
)
)

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Axelen123 Axelen123 added the Bug report Something isn't working label Jul 15, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.68.2](ReVanced/revanced-patches@v2.68.1...v2.68.2) (2022-09-23)

### Bug Fixes

* **hide-time-and-seekbar:** don't draw the seekbar ([ReVanced#594](ReVanced/revanced-patches#594)) ([46e0195](ReVanced/revanced-patches@6f99983))
oSumAtrIX added a commit that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants