Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Duolingo): Add Unlock Duolingo Super patch back again #3420

Closed
wants to merge 1 commit into from

Conversation

notjosh
Copy link
Contributor

@notjosh notjosh commented Jul 8, 2024

Hiya! 👋

A little while ago the Duolingo patch was removed after it stopped working. In this PR I've fixed the old code, and made it work with newer versions of Duolingo.

It's still a little fragile (tho I guess all of ReVanced patches are inherently fragile!), but seems to be working reliably enough for now.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jul 8, 2024

Thanks for the PR! This is unfortunate because our contribution guidelines do not permit pro-unlock patches :/

https://github.com/ReVanced/revanced-patches/blob/main/CONTRIBUTING.md#%EF%B8%8F-guidelines-for-requesting-or-contributing-patches

But this does not mean that you need to scrap your patch, because you can publish your own patches: https://github.com/ReVanced/revanced-patches-template (checkout dev)

I would personally make an exception for this patch according to

We reserve the right to make exceptions for patches that provide significant value.

but I'd like to see if @LisoUseInAIKyrios also approves

@LisoUseInAIKyrios
Copy link
Contributor

They can host it on their own repo. No reason to take on risk with no benefit.

@oSumAtrIX
Copy link
Member

Thanks regardless

@oSumAtrIX oSumAtrIX closed this Jul 8, 2024
@notjosh
Copy link
Contributor Author

notjosh commented Jul 8, 2024

Thanks for the feedback! I read the guidelines before submitting, and ultimately my goal was to achieve this:

Ad-Blocking: Patches aimed at enhancing user privacy and blocking intrusive advertisements are appreciated

I don't really care about the actual "super" features, just to block the ads (which this PR does). Would it be worth rewriting the patch specifically to skip the ad dialogs, if there's a hook I can find to that?

@oSumAtrIX
Copy link
Member

That makes sense. If you can submit an af blocking patch, I'd be happy to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants