feat(YouTube): Support versions 19.25 and 19.37

[zainarbani]

Adds support for versions 19.25.38 and 19.37.39

Except for the Miniplayer patch, all other targets between 19.17 and 19.37 seem to work without any issues. But for simplicity, there is only 2 new recommended versions.
 

Recommended app version

Because of the possibility of unidentified issues and the lack of Restore old seekbar thumbnails support, the recommended app version is still 19.16.39

Bugs, stability, more ads

Both of these new versions may experience more bugs, and possibly some unidentified ads compared to using 19.16.

The recent versions of YouTube have many A/B tests, and you may encounter bugs or partially broken patch features.
 

Seekbar thumbnails

Restore old seekbar thumbnails is not supported on any version after 19.16.39. The code for the old style thumbnails is no longer present and there is no way to restore. If you want the old seekbar thumbnails then continue patching 19.16.39.
 

Miniplayer

The modern miniplayers are still under development by YouTube, and as such there can be bugs and issues while using them.

The later targets both add and remove some miniplayer features.

• 19.25.37 adds miniplayer drag and drop and double tap and pinch to increase the miniplayer size. It is also the last version that can expand/close the miniplayer by swiping (must have both drag and drop and double tap turned off), and the last version with 5 second skip forward/back buttons on Modern 1.
• 19.37.39 The initial miniplayer size can be specified in the settings. Double tap is always on (cannot be turned off).

 

TODO

• Refactor LithoFilter patch (method changed).
• Finish and merge fix(YouTube): Fix issues related to playback by replace streaming data #3582 (this PR is dependent on those changes).
• Fix set start page patch
• Fix why some litho components are inconsistently hiding.
• Verify 18.48 thru 19.29 work.
• Fix SponsorBlock vote & create segment buttons functionality (not working and always shown on player).
• Fix up Miniplayer feature flags, pick a few targets that work well to use for version recommendations
• Fix up Enable slide to seek
• Fix scrolling broken after minimizing video when using 'original' miniplayer

Integration changes

[LisoUseInAIKyrios]

All patches are version bumped, except for Restore old seekbar thumbnails?

The YT code for old seekbar thumbnails is removed after 19.16, so there's no way a patch can force it on.

Do any versions between 19.16 and 19.31 also work?

[LisoUseInAIKyrios]

Since old seekbar patch will remain at 19.16, that means the recommended version will still show as 19.16, but I think for now that is good.

There is many changes and so many a/b tests in the recent YT versions that it's almost certain some users will experience half broke patch functionality or run into new annoying content that has no removal patch. So it's better to recommending 19.16 unless a user wants to opt in to brave patching the latest.

[LisoUseInAIKyrios]

Miniplayer Modern 1 has a layout bug when resuming the app when using a Premium account. If the user was previously watching a video, closes the app, and cold starts again, the video is already opened (Premium feature and expected), but the miniplayer is half off screen and doesn't work.

The issue is also present with 19.32.36,
But 19.30.39 does not have the problem.
I cannot check 19.33 or beyond because GmsCore support fails.

Perhaps this PR should change to 19.30.39 instead, just to fix that?

Edit 1: Changed highest target to 19.30.39

Edit 2: 19.37 is mostly bug free when using Modern 1, and it has a few more features as well.

Edit 3: the premium cold start issues seem to be fixed when client spoofing is working.

[zainarbani]

19.32+ change the com../..ShellActivity class to component (breaks Change start page patch), so i stopped on 19.31.
You can pick this commits to temporarily fix gms patch on 19.32+

[MarcaDian]

I think slide to seek is fixed now

missing player buttons also fixed?

_{PS: I've been testing version 19.34 all this time, I think all adaptation problems have been fixed as for me.
Maybe don't waste time trying to get the old Seekbar thumbnails back now, can always do it later.}

[zainarbani]

@MarcaDian Its fixed on my side, also no more mixed fast forward & slide functionality or labels

ss

Screenrecorder-2024-09-22-18-15-33-360.mp4

[oSumAtrIX]

Please test the unpatched app

[zainarbani]

Please test the unpatched app

Can reproduce on unpatched 19.34.42, either yt bug or new layout changes. 19.38 looks normal.

[zainarbani]

@oSumAtrIX @LisoUseInAIKyrios I think version 19.38.35 is a good option, but it hasn't been released on the Playstore yet.

[Notesure]

Will the old seekbar thumbnail not return forever?

[0xrxL]

@oSumAtrIX @LisoUseInAIKyrios I think version 19.38.35 is a good option, but it hasn't been released on the Playstore yet.

5 days or so and it will be released.

Google has intensified the releases starting from the last month, before the big jump to 20.xx.xx

[0xrxL]

Will the old seekbar thumbnail not return forever?

It will once someone will figure how to fix it but, for the moment, consider the new features/capabilities implemented now.

[MarcaDian]

I think version 19.38.35 is a good option

Confirmed, 19.38.35 doesn't have protobuf issue on my side 🎉 and hiding short components working for me 🤗

Edit: but there new type ads

log.txt

[0xrxL]

I think version 19.38.35 is a good option

Confirmed, 19.38.35 doesn't have protobuf issue on my side 🎉 and hiding short components working for me 🤗

Edit: but there new type ads

log.txt

Mhh...but is still uncertain if it was just a bug or a A/B test.

P.S: Little curiosity: there's also an old public Vanced version which end with the same version number (15.38.35). 😂

[0xrxL]

@zainarbani There is a way to save my eyes from the splashscreen on 19.38? It starting with white color and change to black, once the logo is animated. This issue starting with 19.28 version or so...

[zainarbani]

@zainarbani There is a way to save my eyes from the splashscreen on 19.38? It starting with white color and change to black, once the logo is animated. This issue starting with 19.28 version or so...

I don't get it, like splash animations issue or? If this happens on unpatched app then idk

[0xrxL]

@zainarbani There is a way to save my eyes from the splashscreen on 19.38? It starting with white color and change to black, once the logo is animated. This issue starting with 19.28 version or so...

I don't get it, like splash animations issue or? If this happens on unpatched app then idk

This...

Screen_Recording_20240923_080121_One.UI.Home.mp4

...and yes, it happens on stock too. But it's much annoying.

[zainarbani]

Probably because your system is using a light theme while yt is using a dark theme.
I wonder if splash screen animation could be disabled

[0xrxL]

Nah...I'm on dark mode.

[MarcaDian]

I wonder if splash screen animation could be disabled

Extended by inotia00 has a function to disable splash screen animation.

Do you also have ads on main page on 19.38? Or I am a special lucky guy with a/b tests again 🤗

[zainarbani]

Do you also have ads on main page on 19.38? Or I am a special lucky guy with a/b tests again 🤗

I don't get those visit page type ads

[LisoUseInAIKyrios]

PS: I've been testing version 19.34 all this time, I think all adaptation problems have been fixed as for me. Maybe don't waste time trying to get the old Seekbar thumbnails back now, can always do it later.

I agree, a solution to seekbar thumbnails can come later (if it ever comes at all).

[LisoUseInAIKyrios]

@MarcaDian Do you have litho issues with 19.37?

19.38 has has an integration fingerprint change, and for root install to work perfectly it needs a fix in a different PR (and that PR likely will not be merged before this PR).

[MarcaDian]

Do you have litho issues with 19.37

Ahaha, I'm a lucky guy. There are no problems with the buffer now on 19.37, but a new type of advertisement is present on the main page.

Edit: I may have found why I'm seeing a new ad. I turned on Switch Create with Notifications and the ads no longer appear, but I always move the "Notifications button" to the top.

[MarcaDian]

There is a difference between 19.37.35 and 19.37.39
19.37.35 patched fine, but 19.37.39 has issue

Alternative thumbnails failed: app.revanced.patcher.patch.PatchException: 'Alternative thumbnails' depends on 'IntegrationsPatch' that raised an exception:
app.revanced.patcher.patch.PatchException: Failed to resolve APIPlayerServiceFingerprint