rxjs fails to compile on Typescript 2.6 #2991
Comments
sandersn
added a commit
to sandersn/rxjs
that referenced
this issue
Oct 24, 2017
operator/publishReplay delegates to operators/publishReplay. The call is correct — *one* of the three overloads will be called, and it doesn't matter which — but the compiler has to choose one overload. Previously, the call didn't include type arguments, and the type of the one argument that would be used for inference, selectorOrScheduler, was of type `any`. So the compiler chose the first overload with four parameters. However, the return type of this overload is incorrect, whereas the return type of the third overload is correct. Provide the type arguments explicitly so that the last, most general overload gets called. This results in the the correct return type, `OperatorFunction<T, R>`. Closes ReactiveX#2991
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In src/operator/publishReplay.ts, the delegating call to
higherOrder(which is an alias forpublishReplayin src/operators/publishReplay.ts), has arguments that don't provide enough information to infer type arguments. That's because the third argument is cast toany, which is because it's just a delegation; a call topublishReplaycould delegate to any of the three overloads ofhigherOrder. The compiler has to choose one, however, and it chooses the wrong one in Typescript 2.6.RxJS version:
master
Code to reproduce:
Update typescript to
typescript@nextthen try tonpm run build_allExpected behavior:
No compile error
Actual behavior:
Type
Observable<{}>is not assignable to typeObservable<R> | ConnectableObservable<R>The text was updated successfully, but these errors were encountered: