operator/publishReplay.ts:give type arguments to higherOrder call #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator/publishReplay delegates to operators/publishReplay. The call is correct — *one* of the three overloads will be called, and it doesn't matter which — but the compiler has to choose one overload. This change provides the type arguments explicitly so that the most general overload gets called. This results in the the correct return type, `OperatorFunction<T, R>`.
Generated by 🚫 dangerJS |
-+12.4KB-red.svg?style=flat-square){kind=icon}
-+2.5KB-red.svg?style=flat-square){kind=icon}
|
I couldn't use the commit-hook because it failed to find git.exe on my ancient windows laptop I use at home. I can update the commit message or produce an alternate PR tomorrow when I get back to my linux desktop at work. |
operator/publishReplay delegates to operators/publishReplay. The call is correct — *one* of the three overloads will be called, and it doesn't matter which — but the compiler has to choose one overload. Previously, the call didn't include type arguments, and the type of the one argument that would be used for inference, selectorOrScheduler, was of type `any`. So the compiler chose the first overload with four parameters. However, the return type of this overload is incorrect, whereas the return type of the third overload is correct. Provide the type arguments explicitly so that the last, most general overload gets called. This results in the the correct return type, `OperatorFunction<T, R>`. Closes ReactiveX#2991
…sn/rxjs into fix-compilation-on-ts-2.6
benlesh
approved these changes
Oct 25, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In src/operator/publishReplay.ts, the delegating call to higherOrder (which is an alias for publishReplay in src/operators/publishReplay.ts), has arguments that don't provide enough information to infer type arguments. That's because the third argument is cast to any, which is because it's just a delegation; a call to publishReplay could delegate to any of the three overloads of higherOrder. The compiler has to choose one, however, and it chooses the wrong one in Typescript 2.6.
This change provides the type arguments explicitly so that the most general overload gets called. This results in the the correct return type,
OperatorFunction<T, R>.Related issue (if exists):
#2991