Switch Maybe and Single to use their Transformers in compose() #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
commented
Oct 1, 2016
| @@ -1967,13 +1967,12 @@ public final T blockingGet(T defaultValue) { | |||
| * </dl> | |||
| * | |||
| * @param <R> the value type of the Maybe returned by the transformer function | |||
| * @param transformer | |||
| * implements the function that transforms the source Maybe | |||
| * @param transformer the transformer function, not null | |||
There was a problem hiding this comment.
Note that I just borrowed from the Completable.compose() doc wording here
|
Whoops forgot to update the tests, will update in a sec |
|
IntelliJ user I presume? |
|
Indeed... Does (I presume 😉) eclipse do something to protect against this? |
|
Eclipse has an error view which doesn't obscure the project structure, plus when one shows the breadcrumbs, they get error icons indicating there's still something wrong (also the project tree gets error icons) so it is much harder to miss these kinds of errors. |
Current coverage is 77.87% (diff: 100%)@@ 2.x #4651 diff @@
==========================================
Files 559 559
Lines 36654 36654
Methods 0 0
Messages 0 0
Branches 5625 5625
==========================================
- Hits 28560 28543 -17
- Misses 6065 6078 +13
- Partials 2029 2033 +4
|
|
Interesting, I'll have to check that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4650