-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Document and test amb subscription ordering. #5047
Conversation
Once wording and tests are approved I'll port to 1.x as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
(Forgot about testing all signal types as well, so 5 x 3 x 3, but I don't require it.)
Hmm I seem to be fighting the cool documentation checker which is being a bit too clever in this instance. I'm using the word "Subscription" at the beginning of a sentence which it thinks means |
Also with regard to signal types, I figure the other tests cover those already so in these cases we're just guarding against ordering changes. |
Yes, lowercase it as |
Codecov Report@@ Coverage Diff @@
## 2.x #5047 +/- ##
===========================================
+ Coverage 95.52% 95.6% +0.08%
- Complexity 5539 5541 +2
===========================================
Files 612 612
Lines 39576 39576
Branches 5553 5553
===========================================
+ Hits 37804 37838 +34
+ Misses 773 758 -15
+ Partials 999 980 -19
Continue to review full report at Codecov.
|
Refs #5044.