Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: add nullable annotation to simple queue (fixes #5053) #5054

Merged

Conversation

jschneider
Copy link
Contributor

As explained in #5053 SimpleQueue might return null.
To document this behavior a nullable annotation has been added.

@akarnokd akarnokd added this to the 2.0 backlog milestone Feb 3, 2017
@codecov
Copy link

codecov bot commented Feb 3, 2017

Codecov Report

Merging #5054 into 2.x will increase coverage by 0.01%.

@@             Coverage Diff              @@
##                2.x    #5054      +/-   ##
============================================
+ Coverage     95.65%   95.67%   +0.01%     
+ Complexity     5546     5543       -3     
============================================
  Files           612      612              
  Lines         39576    39576              
  Branches       5553     5553              
============================================
+ Hits          37857    37863       +6     
- Misses          737      744       +7     
+ Partials        982      969      -13
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/observable/ObservableFromArray.java 100% <ø> (ø) 3 <ø> (ø)
...rnal/operators/observable/ObservableRangeLong.java 100% <ø> (ø) 2 <ø> (ø)
...perators/maybe/MaybeFlatMapIterableObservable.java 98.66% <ø> (ø) 2 <ø> (ø)
...vex/internal/operators/flowable/FlowableRange.java 96.9% <ø> (ø) 3 <ø> (ø)
...x/internal/operators/flowable/FlowableGroupBy.java 95.01% <ø> (-0.63%) 2 <ø> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <ø> (ø) 28 <ø> (ø)
...eactivex/internal/disposables/EmptyDisposable.java 100% <ø> (ø) 17 <ø> (ø)
...nal/operators/observable/ObservableScalarXMap.java 96.55% <ø> (ø) 7 <ø> (ø)
...internal/operators/flowable/FlowableObserveOn.java 97.1% <ø> (+1.15%) 3 <ø> (ø)
...internal/operators/flowable/FlowableRangeLong.java 91.75% <ø> (ø) 3 <ø> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8720828...9c62d2f. Read the comment docs.

@akarnokd akarnokd merged commit e5d3b0e into ReactiveX:2.x Feb 3, 2017
@akarnokd akarnokd changed the title add nullable annotation to simple queue (fixes #5053) 2.x: add nullable annotation to simple queue (fixes #5053) Feb 3, 2017
@jschneider jschneider deleted the feature/#5053-simple-queue-nullable branch February 3, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants