Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix CallbackCompletableObserver calling onError, ResourceX wording #5240

Merged
merged 1 commit into from
Mar 27, 2017

Conversation

akarnokd
Copy link
Member

This PR contains the fix for incorrect call of the onError handler within CallbackCompletableObserver.onComplete() reported in 5099 as well as wording fixes to the ResourceX javadoc.

@akarnokd akarnokd added this to the 2.0 backlog milestone Mar 27, 2017
@codecov
Copy link

codecov bot commented Mar 27, 2017

Codecov Report

Merging #5240 into 2.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5240      +/-   ##
============================================
+ Coverage     96.12%   96.15%   +0.02%     
- Complexity     5757     5758       +1     
============================================
  Files           628      628              
  Lines         41074    41073       -1     
  Branches       5697     5697              
============================================
+ Hits          39484    39495      +11     
+ Misses          630      616      -14     
- Partials        960      962       +2
Impacted Files Coverage Δ Complexity Δ
.../io/reactivex/observers/ResourceMaybeObserver.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...io/reactivex/observers/ResourceSingleObserver.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...activex/observers/ResourceCompletableObserver.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...ava/io/reactivex/observers/DisposableObserver.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...nternal/observers/CallbackCompletableObserver.java 100% <100%> (ø) 9 <0> (ø) ⬇️
...vex/internal/operators/single/SingleTakeUntil.java 86.88% <0%> (-8.2%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 91.5% <0%> (-5.23%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.1% <0%> (-3.51%) 10% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-3.39%) 10% <0%> (-1%)
...activex/internal/subscribers/FutureSubscriber.java 96.82% <0%> (-3.18%) 32% <0%> (-1%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851de41...256674b. Read the comment docs.

@akarnokd akarnokd merged commit b717c89 into ReactiveX:2.x Mar 27, 2017
@akarnokd akarnokd deleted the Cleanup327 branch March 27, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants