2.x: fix doOnNext failure not triggering doOnError when fused #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Jun 14, 2017
| } catch (Throwable exc) { | ||
| throw new CompositeException(ex, exc); | ||
| } | ||
| throw ExceptionHelper.<Exception>throwIfThrowable(ex); |
There was a problem hiding this comment.
Hmm I don't understand why we both signal onError and also re-throw. It seems like it should be one or the other, no?
There was a problem hiding this comment.
Because this matches how doOnError would be called with the upstream error and then that error is forwarded to the next operator.
Codecov Report
@@ Coverage Diff @@
## 2.x #5415 +/- ##
==========================================
+ Coverage 96.1% 96.2% +0.09%
- Complexity 5778 5794 +16
==========================================
Files 630 630
Lines 41197 41232 +35
Branches 5728 5728
==========================================
+ Hits 39593 39667 +74
+ Misses 631 612 -19
+ Partials 973 953 -20
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Jun 14, 2017
| * @throws E the generic exception thrown | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public static <E extends Throwable> Exception throwIfThrowable(Throwable e) throws E { |
There was a problem hiding this comment.
@CheckReturnValue
| * @throws E the generic exception thrown | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public static <E extends Throwable> Exception throwIfThrowable(Throwable e) throws E { |
There was a problem hiding this comment.
Maybe throwIfThrowableOrReturn?
vanniktech
approved these changes
Jun 15, 2017
This was referenced Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when in a fused chain of
doOnNextanddoOnErrorthedoOnNextfunction fails, thedoOnErrorconsumer is not called.Originally reported in Reactor-Core: reactor/reactor-core#664