Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: concat to report isDisposed consistently with termination #5440

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

akarnokd
Copy link
Member

This PR makes sure the Disposable of a concat operator reports true when the sequence terminates.

Reported in #5439

@akarnokd akarnokd added this to the 2.2 milestone Jun 26, 2017
@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #5440 into 2.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5440      +/-   ##
============================================
- Coverage     95.96%   95.93%   -0.04%     
- Complexity     5793     5794       +1     
============================================
  Files           631      631              
  Lines         41297    41302       +5     
  Branches       5744     5744              
============================================
- Hits          39632    39622      -10     
- Misses          663      667       +4     
- Partials       1002     1013      +11
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/observable/ObservableConcatMap.java 97.52% <100%> (+0.05%) 5 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 78.63% <0%> (-18.81%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
.../internal/operators/observable/ObservableHide.java 90% <0%> (-5%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 93.87% <0%> (-4.09%) 2% <0%> (ø)
...io/reactivex/internal/util/BackpressureHelper.java 95.91% <0%> (-4.09%) 21% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 96% <0%> (-4%) 33% <0%> (-2%)
...l/operators/observable/ObservableFlatMapMaybe.java 84.96% <0%> (-3.93%) 2% <0%> (ø)
...vex/internal/operators/flowable/FlowableTimer.java 92.85% <0%> (-3.58%) 2% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-3.39%) 10% <0%> (-1%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a83b3...af45f4e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants