Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of Main thread from Schedulers.single() javadoc. #5706

Merged

Conversation

artem-zinnatullin
Copy link
Contributor

To avoid confusion.

One could think that single() can be used to execute code on "Main" thread.

@@ -243,9 +243,9 @@ public static Scheduler newThread() {
* <p>
* Uses:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't really understand use of "Uses" here… so if you have some suggestions, I could update this as well

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #5706 into 2.x will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5706      +/-   ##
============================================
+ Coverage     96.26%   96.32%   +0.06%     
- Complexity     5821     5825       +4     
============================================
  Files           634      634              
  Lines         41604    41604              
  Branches       5761     5761              
============================================
+ Hits          40049    40077      +28     
+ Misses          618      602      -16     
+ Partials        937      925      -12
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/schedulers/Schedulers.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 86.97% <0%> (-4.69%) 57% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 94.77% <0%> (-1.5%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.28% <0%> (-1.42%) 32% <0%> (-1%)
...vex/internal/operators/flowable/FlowableCache.java 92.61% <0%> (-1.35%) 7% <0%> (ø)
...nal/operators/flowable/FlowableConcatMapEager.java 97.1% <0%> (-1.16%) 2% <0%> (ø)
...ivex/internal/operators/maybe/MaybeMergeArray.java 96.62% <0%> (-1.13%) 6% <0%> (ø)
...tors/observable/ObservableSequenceEqualSingle.java 98.29% <0%> (-0.86%) 3% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6c9f5...3d7550d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants