Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Improve Javadocs of flatMapSingle and flatMapMaybe #5709

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Nov 8, 2017

Clarify that flatMapSingle and flatMapMaybe merge in no particular order and fix the copy-paste error from flatMapCompletable as they have values to merge, not just waiting.

Related: StackOverflow question

@akarnokd akarnokd added this to the 2.2 milestone Nov 8, 2017
@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #5709 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5709      +/-   ##
===========================================
- Coverage     96.3%   96.29%   -0.01%     
- Complexity    5821     5822       +1     
===========================================
  Files          634      634              
  Lines        41604    41604              
  Branches      5761     5761              
===========================================
- Hits         40068    40064       -4     
- Misses         608      612       +4     
  Partials       928      928
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 525 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 508 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 79.48% <0%> (-18.81%) 2% <0%> (ø)
...tivex/internal/schedulers/InstantPeriodicTask.java 61.11% <0%> (-5.56%) 7% <0%> (-2%)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-3.81%) 2% <0%> (ø)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 92.47% <0%> (-2.16%) 9% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1099084...dd43f7a. Read the comment docs.

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants