Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: add a couple of @see to Completable #5758

Merged
merged 2 commits into from
Dec 10, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 8, 2017

This PR adds a couple of @see cross references to Completable JavaDoc.

@akarnokd akarnokd added this to the 2.2 milestone Dec 8, 2017
@codecov
Copy link

codecov bot commented Dec 8, 2017

Codecov Report

Merging #5758 into 2.x will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5758      +/-   ##
============================================
- Coverage     96.31%   96.27%   -0.05%     
- Complexity     5838     5840       +2     
============================================
  Files           634      634              
  Lines         41653    41653              
  Branches       5769     5769              
============================================
- Hits          40118    40101      -17     
- Misses          603      616      +13     
- Partials        932      936       +4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 115 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 90.26% <0%> (-5.76%) 61% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-2.64%) 11% <0%> (+1%)
...l/operators/observable/ObservableFlatMapMaybe.java 87.58% <0%> (-2.62%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.56% <0%> (-1.64%) 2% <0%> (ø)
...nal/operators/flowable/FlowableConcatMapEager.java 97.1% <0%> (-1.16%) 2% <0%> (ø)
...vex/internal/operators/parallel/ParallelRunOn.java 96.61% <0%> (-0.97%) 8% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34242e1...de4c4a2. Read the comment docs.

@akarnokd akarnokd merged commit b338ffe into ReactiveX:2.x Dec 10, 2017
@akarnokd akarnokd deleted the JavadocImprovements1208 branch December 10, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants