-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add missing {Maybe|Single}.mergeDelayError variants #5799
Conversation
* | ||
* @param <T> the common value type | ||
* @param source1 | ||
* a Single to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it's a SingleSource
. dunno whether you want to distinguish between them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it as Maybe.merge()
say "a MaybeSource to be merged".
Codecov Report
@@ Coverage Diff @@
## 2.x #5799 +/- ##
===========================================
+ Coverage 96.29% 96.3% +<.01%
- Complexity 5808 5812 +4
===========================================
Files 634 634
Lines 41631 41647 +16
Branches 5776 5776
===========================================
+ Hits 40090 40108 +18
+ Misses 605 597 -8
- Partials 936 942 +6
Continue to review full report at Codecov.
|
This PR adds
mergeDelayError
overloads toMaybe
andSingle
; the infrastructure was there from the beginning but thedelayErrors == true
settings were not exposed publicly.Maybe.mergeDelayError(Publisher, int)
Single.mergeDelayError(Iterable)
Single.mergeDelayError(Publisher)
Single.mergeDelayError(SingleSource, SingleSource)
Single.mergeDelayError(SingleSource, SingleSource, SingleSource)
Single.mergeDelayError(SingleSource, SingleSource, SingleSource, SingleSource)