Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: ThrottleWithTimeout+Consumer cleanup #7511

Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 9, 2023

  • Add missing history and experimental annotations.
  • Allow contravariance for the consumer.
  • Rename local variables for clarity.

Related: #7510

@akarnokd akarnokd added this to the 3.1-support milestone Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #7511 (35abd6e) into 3.x (bf8da15) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x    #7511      +/-   ##
============================================
+ Coverage     99.50%   99.56%   +0.05%     
- Complexity     6797     6798       +1     
============================================
  Files           752      752              
  Lines         47675    47673       -2     
  Branches       6400     6400              
============================================
+ Hits          47441    47467      +26     
+ Misses          110       95      -15     
+ Partials        124      111      -13     
Impacted Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
...rnal/operators/flowable/FlowableDebounceTimed.java 100.00% <100.00%> (ø)
.../operators/observable/ObservableDebounceTimed.java 100.00% <100.00%> (ø)
...tivex/rxjava3/internal/schedulers/IoScheduler.java 97.91% <0.00%> (-2.09%) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 96.37% <0.00%> (-0.52%) ⬇️
...a3/internal/operators/flowable/FlowableCreate.java 99.02% <0.00%> (-0.33%) ⬇️
...operators/flowable/FlowableConcatMapScheduler.java 99.60% <0.00%> (+0.39%) ⬆️
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 99.58% <0.00%> (+0.41%) ⬆️
...nternal/operators/observable/ObservableCreate.java 98.29% <0.00%> (+0.85%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akarnokd akarnokd merged commit e1b6cb4 into ReactiveX:3.x Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants