Don't retain receiver of Completable.andThen beyond its completion #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaykasyanov
commented
May 24, 2024
| private let subscription = SerialDisposable() | ||
|
|
||
| init(parent: Parent, observer: Observer, cancel: Cancelable) { | ||
| self.parent = parent |
There was a problem hiding this comment.
I'm not sure whether not retaining parent is the right thing to do.
There was a problem hiding this comment.
This feels very much like the change I made for the deferred code (214f7ff). If the Completable has emitted a completed event, there is no reason to keep it around.
There was a problem hiding this comment.
@danielt1263 indeed! Given its similarity to the deferred fix, I wonder if this PR can be considered for a minor release? cc @freak4pc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the creation closure and operator closures involved in the Completable (and hence all objects captured by them) are retained until the outer stream completes or terminates with error.