Added some documentations to AsyncLock file #2627
Conversation
|
@herlandro thanks for this addition. There are some failed workflow, I dont know what is the cause of failing these workflows. Could you please try to fix these? |
|
@ankushkushwaha I saw that most of the PRs made after July 17th presented the same workflow test error. In all the logs I analyzed, the error is the same:
The first file that we can attack is: .github/workflows/tests.yml |
|
The main issue is that the CI is still using an older version of Xcode, I'll try to get to tackling it soon and bump to Xcode 16. |
|
@freak4pc Did you see about the Xcode update to version 16? |
.github/workflows/tests.yml
Outdated
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y curl libssl-dev | ||
| git clone https://github.com/kylef/swiftenv.git ~/.swiftenv | ||
| echo 'export SWIFTENV_ROOT="$HOME/.swiftenv"' >> ~/.bashrc | ||
| echo 'export PATH="$SWIFTENV_ROOT/bin:$PATH"' >> ~/.bashrc | ||
| echo 'eval "$(swiftenv init -)"' >> ~/.bashrc | ||
| export SWIFTENV_ROOT="$HOME/.swiftenv" | ||
| export PATH="$SWIFTENV_ROOT/bin:$PATH" | ||
| eval "$(swiftenv init -)" | ||
| swiftenv install 5.5 | ||
| swiftenv global 5.5 | ||
| swift --version | ||
|
|
There was a problem hiding this comment.
I'm unsure how this change relates to documentation updates. Would you mind removing it from this PR and have a separate one with an explanation on why it's needed?
|
I've rebased your branch - Thanks 🙏 |
There was a problem hiding this comment.
Ok, so - tl;dr
I personally don't think it's usually worth the effort to document so deeply the internal layers of RxSwift, since it's not public interface that consumers are using -
But since you've already done this, it definitely doesn't hurt. Thank you for the work!
No description provided.