-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(buffer): emit last buffer if source completes
Fix buffer operator not emitting the last buffer when the source completes. This is closer to rxjs v4* behaviour and matches the behaviour of the other buffer operators. The _complete method is very similar to thoses in bufferCount, bufferTime and bufferWhen. *rxjs v4 will always emit the buffer if the source completes even if the buffer is empty. This fix only emits if the buffer is non empty. BREAKING CHANGE: extra value maybe emitted when source completes
- Loading branch information
Ben Farr
committed
Dec 7, 2016
1 parent
89b506d
commit 132af2f
Showing
2 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters