Skip to content

Commit

Permalink
refactor(groupBy-spec): rename comparer to keySelector
Browse files Browse the repository at this point in the history
  • Loading branch information
Andre Medeiros authored and benlesh committed Oct 13, 2015
1 parent 8bfb23e commit 45b8ebd
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions spec/operators/groupBy-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source).toBe(expected, expectedValues);
});

it('should group values with a key comparer', function () {
it('should group values with a keySelector', function () {
var values = {
a: ' foo',
b: ' FoO ',
Expand Down Expand Up @@ -163,7 +163,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source).toBe(expected, expectedValues);
});

it('should group values with a key comparer, assert GroupSubject key', function () {
it('should group values with a keySelector, assert GroupSubject key', function () {
var values = {
a: ' foo',
b: ' FoO ',
Expand All @@ -188,7 +188,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source).toBe(expected, expectedValues);
});

it('should group values with a key comparer, but outer throws', function () {
it('should group values with a keySelector, but outer throws', function () {
var values = {
a: ' foo',
b: ' FoO ',
Expand All @@ -213,7 +213,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source).toBe(expected, expectedValues);
});

it('should group values with a key comparer, inners propagate error from outer', function () {
it('should group values with a keySelector, inners propagate error from outer', function () {
var values = {
a: ' foo',
b: ' FoO ',
Expand Down Expand Up @@ -267,7 +267,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source, unsub).toBe(expected, expectedValues);
});

it('should group values with a key comparer, but comparer throws', function () {
it('should group values with a keySelector which eventually throws', function () {
var values = {
a: ' foo',
b: ' FoO ',
Expand Down Expand Up @@ -302,7 +302,7 @@ describe('Observable.prototype.groupBy()', function () {
expectObservable(source).toBe(expected, expectedValues);
});

it('should group values with a key comparer and elementSelector, ' +
it('should group values with a keySelector and elementSelector, ' +
'but elementSelector throws',
function () {
var values = {
Expand Down

0 comments on commit 45b8ebd

Please sign in to comment.