Skip to content

Commit

Permalink
docs(Observable): fix typos
Browse files Browse the repository at this point in the history
I'm not sure I made correct changes, but it definitely feels like something is missing in current docs here:
> Each call to observable.subscribe triggers its own independent for that given Observer.
It seems like a word belongs after "independent", but I'm not sure what, so I just suggested "setup".

And for this one:
> This shows how a subscribe calls are not at all shared among multiple Observers of the same Observable.
My removal of "a" is fixing a typo, but my removal of "at all" is just simplification. I see why you might want to keep it for emphasis.
  • Loading branch information
RebootJeff committed Apr 14, 2016
1 parent 815f775 commit ae33a46
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/observable.md
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ observable.subscribe(x => console.log(x));

It is not a coincidence that `observable.subscribe` and `subscribe` in `Observable.create(function subscribe(observer) {...})` have the same name. In the library, they are different, but for practical purposes you can consider them conceptually equal.

This shows how a `subscribe` calls are not at all shared among multiple Observers of the same Observable. When calling `observable.subscribe` with an Observer, the function `subscribe` in `Observable.create(function subscribe(observer) {...})` is run for that given Observer. Each call to `observable.subscribe` triggers its own independent for that given Observer.
This shows how `subscribe` calls are not shared among multiple Observers of the same Observable. When calling `observable.subscribe` with an Observer, the function `subscribe` in `Observable.create(function subscribe(observer) {...})` is run for that given Observer. Each call to `observable.subscribe` triggers its own independent setup for that given Observer.

<span class="informal">Subscribing to an Observable is like calling a function, providing callbacks where the data will be delivered to.</span>

Expand Down

0 comments on commit ae33a46

Please sign in to comment.