Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.from('string') browser compatibility #1147

Closed
kwonoj opened this issue Jan 7, 2016 · 4 comments
Closed

Observable.from('string') browser compatibility #1147

kwonoj opened this issue Jan 7, 2016 · 4 comments
Assignees
Labels
bug Confirmed bug

Comments

@kwonoj
Copy link
Member

kwonoj commented Jan 7, 2016

Observable.from can take string and iterate it as

Rx.Observable.from('foo').subscribe(console.log);
// => Next: f
// => Next: o
// => Next: o
// => Completed

but fails to do it on some browsers does not support string iterator (IE, for example)

in RxJS4, seems it has own iterator for string object (https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/from.js#L3-L23) to support this behavior - does RxJS5 need to port same behavior?

I've used https://jsfiddle.net/v0w220v6/ to test out between different browsers.

@kwonoj
Copy link
Member Author

kwonoj commented Jan 7, 2016

related to #998 .

@benlesh
Copy link
Member

benlesh commented Jan 8, 2016

I believe some of the infrastructure for this is already in place. So there might be a bug.

@kwonoj
Copy link
Member Author

kwonoj commented Jan 11, 2016

I assume it's StringIteratror in IteratorObservable, will try to look into what's happening. Marking this as bug meanwhile.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants